Skip to content

Implement JSON schema compatibility check - #167

Merged
ravisuhag merged 39 commits into
mainfrom
json-compatibility
Oct 26, 2023
Merged

ravisuhag merged 39 commits into
mainfrom
json-compatibility

Conversation

@punit-kulal

@punit-kulal punit-kulal commented Sep 27, 2023 •

Copy link
Copy Markdown
Contributor

Features

  • Support all drafts of json schema, take default as 2020 when schema draft version is not defined.
  • Only supports testing of open model json schema (additional properties is true) and fails with error if that's not the case.
  • Support only json Backward compatibility test.

Changes

  • Bump go version to 1.20 due to updated jsonschema library(requires >1.19) and use of generics (requires >1.20)
  • Update pipelines to use newer version of earlier used actions.
  • Implement backward compatibility check for open content model.
    • No field delete.
    • Specifying additional properties is prohibited. (To ensure open content model)
    • No change in required fields.
    • No change in external or internal ref
    • Type specific checks(Type change)
    • No change schema validation condition for allOf
    • Only addition for schema validation condition like oneOf, anyOf

Not in scope

  • Add tests for explore subfunctions.
  • Validation keyword conflicts

@ravisuhag
ravisuhag requested a review from h4rikris September 29, 2023 01:41
@punit-kulal
punit-kulal marked this pull request as ready for review October 3, 2023 06:56
Comment thread formats/json/compatibility.go Resolved
Comment thread formats/json/compatibility.go Resolved
Comment thread formats/json/utils.go Resolved
@ravisuhag
ravisuhag merged commit efce4da into main Oct 26, 2023
@ravisuhag
ravisuhag deleted the json-compatibility branch October 26, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants