Repository navigation
add standard tags for db and redis suggested by OTEL - #8
Merged
Merged
Conversation
subintp
reviewed
Feb 11, 2021
| 'db.system' => 'redis', | ||
| 'db.connection_string' => $connection_str, | ||
| 'redis.connection' => $connection_str, | ||
| 'span.kind' => Span::KIND_CLIENT |
There was a problem hiding this comment.
Can we take these tags from constants module or file ?
subintp
approved these changes
Feb 12, 2021
asldevi
force-pushed
the
otel-standard-tags-db-redis
branch
from
February 24, 2021 14:54
7fa3176 to
9994a45
Compare
1. remove non standard redis.connection tag, blocking redis to be recognized as backend 2. for mysql dsn without host, take host as an optional param to PDO load
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add standard tags for db and redis suggested by open telemetry and for better readability of spans from Jaeger/HT
UI.