Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It addresses the behavior reported in issue #1327.
fix: stop packaging libsqliteJni.so on Android
Fixes #1327
Test Plan
Ran
yarn run test:lintlocally on macOS for the async-storage change; it fails the same way on the base branch, so the failure predates this change (it fails the same way on upstream/main).A run with the async-storage change reverted gave no clear result, so no test is shown to catch this bug.
The new test shared-storage/src/androidHostTest/kotlin/tests/BundledSqliteAbsentOnAndroidTest.kt did not run here: no test runner for it was available.