Skip to content
This repository was archived by the owner on Jun 16, 2023. It is now read-only.
This repository was archived by the owner on Jun 16, 2023. It is now read-only.

Swift Rewrite #5

Open
Open

Description

@MarcoScabbiolo

Rewrite the native code for core and barcode in Swift.
Exclude any unused code (face detection, etc.), clean up the surface API for ease of usage and review portability with the Android API.

Swiftify can help a lot

Activity

  1. changed the title [-]iOS Rewrite[/-] [+]Swift Rewrite[/+] on Feb 8, 2021
  2. cristianoccazinsp commented on Mar 2, 2021

    @cristianoccazinsp

    @MarcoScabbiolo while you are at it, you may want to consider also removing some of the deprecated API calls. More specifically, captureStillImageAsynchronouslyFromConnection is deprecated, and so most of the classes related to it (https://developer.apple.com/documentation/avfoundation/avcapturestillimageoutput?language=objc).

    Not swift, but here's an example of the code migration for the new API: https://stackoverflow.com/questions/39872528/ios-10-objective-c-how-to-implement-avcapturephotooutput-to-capture-image

  3. added a commit that references this issue on Mar 2, 2021
  4. raimonkh commented on Sep 30, 2021

    @raimonkh

    Is there a plan to remove writeImageDataToSavedPhotosAlbum ? from the deprecated ALAssetsLibrary? Can we help?
    v4 was released with what seems Android rewrite, but not iOS rewrite, am I right?

  5. MarcoScabbiolo commented on Oct 4, 2021

    @MarcoScabbiolo
    Author

    @raimonkh Please see: react-native-camera/react-native-camera#3000 (comment) . If anyone wants to keep going with the v4, its all yours, but know that our vision for it is already achieved in react-native-vision-camera

  6. raimonkh commented on Oct 4, 2021

    @raimonkh

    Thanks @MarcoScabbiolo 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions