Skip to content

ESLint is not picking up 'react-hooks/exhaustive-deps' #10545

Closed

Description

@ronaldgj

I use the newest version of create-react-app, but I don't get any errors / warnings when I use a variable or function in a useEffect hook and don't add them to the dependency list.

import { FC, useEffect, useState } from "react";
import Modal from "./lib/modal";

const App: FC = () => {
  const [showModal, setShowModal] = useState(false);

  const handleClose = () => {
    if (showModal) {
      setShowModal(false);
    }
  };

  useEffect(() => {
    
    /* Don't get any warning for 'showModal' */
    if (showModal) {
      console.log("es lint test");
    }
  }, []);

  return (
    <>
      <button onClick={() => setShowModal(true)}>Open Modal</button>
      <Modal show={showModal} onClose={handleClose} />
    </>
  );
};

export default App;

Schermafbeelding 2021-02-12 om 22 18 13

Activity

  1. ronaldgj commented on Feb 15, 2021

    @ronaldgj
    Author

    I'm sorry.. I searched and read the changelog some better and I found out I had to add the ESLINT_NO_DEV_ERRORS=true to the .env file.

    Everything works as normal now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions