Repository navigation
Suppress unwanted warnings #1947
Description
As of webpack/webpack#4381 webpack will (once released) allow to suppress warnings as requested here: webpack/webpack#4263 .
Happy to help out with a PR, if you can specify what is wanted, wanted to be suppressed
Activity
timse commentedon Apr 7, 2017
followup from #1924 @Timer
Timer commentedon Apr 8, 2017
Perfect, we'll try to take a look at this soon, probably after the 0.10 release which should be by the end of the month.
We'll have to work out the details and wait on the webpack release anyway. 😄
kellyrmilligan commentedon May 10, 2017
man I need this! localForage gives the prebuilt file warning, so in CI it breaks. :(
kellyrmilligan commentedon May 10, 2017
is there any workaround to this ATM?
FredrikNoren commentedon May 10, 2017
@kellyrmilligan This hack:
CI=false yarn build(not sure what other implications setting CI to false has though)levrik commentedon May 25, 2017
@FredrikNoren This doesn't work for me... Do you have an idea why?
gaearon commentedon May 25, 2017
@levrik
What warnings exactly are you trying to suppress? The ones in this issue don’t seem to fire with latest versions.
levrik commentedon May 25, 2017
@gaearon I want to suppress some linting warnings that are preventing the production deployment or... I don't really want to suppress them. I only want that they don't block the deployment.
levrik commentedon May 25, 2017
@FredrikNoren @gaearon Ok
unset CI yarn build CI=truedid the trick. Seems like it's only checking for the existence of the CI variable and not for the content.
mileung commentedon Jun 9, 2017
Would be nice to suppress warnings like "warning 'variable' is assigned a value but never used no-unused-vars". I usually just duplicate a template folder to create a new component and they import things that haven't been used yet, so I get this warning a lot.
midastouchprd commentedon Jul 3, 2017
@mileung
/* eslint-disable no-unused-vars*/at the top of your files
should give you what you want
gaearon commentedon Jul 3, 2017
@mileung This warning is valuable for catching some very annoying mistakes though.
mileung commentedon Jul 3, 2017
@gaearon Probably, but I don't think importing something or making a new variable would cause anything to break; at least not in my current project.
gaearon commentedon Jul 3, 2017
It’s sometimes a sign of a mistake in logic. For example if you read some parameter but forget to use it. So it might not “break” things but might indicate that the code doesn’t do what you think it does. As for imports, it is valuable for catching unused imports that bloat the bundle. For example if you import a whole library in the main bundle but it’s only necessary in code split chunks.
JReinhold commentedon Aug 1, 2017
I support this issue, it is especially relevant when getting warnings caused by other dependencies way down the dependency-tree. We can't find a way to get around this warning:
(the specific warning type is discussed in other issues, this was just to give an example that would support the issue of suppressing warnings).
So #1947 (comment) was a life safer for us.
missbruni commentedon Aug 24, 2017
I know webpack has added a warning filter to their config but this does not solve our problem when getting warnings from other dependencies and not having access to configuration. Any solutions ?
TSMMark commentedon Nov 17, 2017
React's deprecation warnings after an upgrade cause Capybara PhantomJS to fail builds on CI. My temporary workaround was settings
js_errors: false. Terrible bandaid, but now warnings aren't blocking deploys.Now obviously the next step is to set
js_errors: trueand hunt down and fix every single warning. Fungaearon commentedon Jan 8, 2018
@isbdnt This doesn't solve anything for CRA users and is not relevant to this repository.
@TSMMark This issue is about build-time warnings and has nothing to do with React (runtime) warnings.
gaearon commentedon Jan 8, 2018
Going to close this as stale. Please raise a new issue with more details if you're interested in this.