Repository navigation
current eslint-config-react-app a little too restrictive for common use #2793
Description
Its set to
'no-cond-assign': ['warn', 'always'],
when it should be ( actually the default )
'no-cond-assign': ['warn', 'except-parens'],
Why is this important. For example, it makes the proper use of iterating of global regex matches whiney.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/exec
var myRe = /ab*/g;
var str = 'abbcdefabh';
var myArray;
while ((myArray = myRe.exec(str)) !== null) {
var msg = 'Found ' + myArray[0] + '. ';
msg += 'Next match starts at ' + myRe.lastIndex;
console.log(msg);
}
Reacted by Marek Lenik and Mikaël Vaivre
Activity
Timer commentedon Jul 25, 2017
I don't feel super strongly about this either way; options, @gaearon?
Relax no-cond-assign rule
Relax no-cond-assign rule (#3716)
gaearon commentedon Jan 15, 2018
The fix is out in
react-scripts@1.1.0! Please let us know if something doesn’t quite work.https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0
Relax no-cond-assign rule (react#3716)
Relax no-cond-assign rule (react#3716)