Repository navigation
Make launch editor a standalone package. #4091
Description
The launchEditor module is super useful: https://github.com/facebook/create-react-app/blob/next/packages/react-dev-utils/launchEditor.js
I'd like to use it standalone, outside of create-react-app. Is there anyone willing to send a PR to make this a standalone package? :)
Reacted by Karl Horky
Activity
egoist commentedon Feb 28, 2018
You mean https://github.com/yyx990803/launch-editor?
cpojer commentedon Feb 28, 2018
Oh cool! Nevermind then – wondering why create-react-app isn't using this though.
SimenB commentedon Feb 28, 2018
Or https://github.com/sindresorhus/open-editor
Timer commentedon Feb 28, 2018
It looks like we added that file mere days after sindresorhus created his module, May 4th vs 14th so we probably didn't know about it.
launch-editoris extracted from our code base, so its effectively the same thing.We should probably turn this into a module, it looks like
open-editordoesn't have as much editor support and this would just be an official version oflaunch-editor.gaearon commentedon Feb 28, 2018
I don't think @yyx990803 reached out to suggest extracting it before forking. We'd be happy to collab on this and keep it as a separate package.
gaearon commentedon Feb 28, 2018
(Didn't mean it in a bad way—I also fork a lot of stuff all the time because it takes time to establish relationships etc. But I'd be happy to give @yyx990803 commit rights in this repo and continue maintaining it here :-)
yyx990803 commentedon Feb 28, 2018
Yeah, I just assumed
create-react-appkept it insidereact-dev-utilsfor a reason (like all the other utils in there) so didn't make that suggestion.Another reason I forked it is mostly because I may need to make changes that make it incompatible with the needs of
create-react-app. If you guys are happy with the current API oflaunch-editorI'd be happy to collaborate.