Repository navigation
error when requiring node modules that use destructuring #415
Description
I have a node module, where in it's lib there is a file like so:
lib/foo.js
const {APPID} = require('./config');
within App.js, when I require this module
App.js
const myModule = require('myModule/lib/foo')
Now, when I load this in the browser, an error is thrown
Unexpected Token {
This is because webpack has required myModule/lib/foo.js, but has not done any processing on it -- the destructuring is not converted.
This makes sense, as it is indeed a node module outside of our app.
Is there a recommended solution to solve this? I could eject and try to update configuration, but am wishing there is another way
Activity
stopachka commentedon Aug 10, 2016
nevermind, am closing this, as I presume it would be against the spirit of create-react-app to allow this much customization. will eject and update the excludes regex
gaearon commentedon Aug 10, 2016
It is not recommended to run Babel on
node_modules. This is known to break some libraries, and also is terribly slow. The ecosystem convention so far has been to precompile libraries to ES5 before shipping them to npm—at least for the libraries meant to be consumed in the browser.