Skip to content

Add tests for extending ESLint #7519

Closed as not planned
Closed as not planned

Description

@ianschmitz

This is a good first PR!

We should add some tests to cover #7036. They should cover both JavaScript and TypeScript support.

They can probably be added to test/fixtures.

Activity

  1. added this to the 3.x milestone on Aug 13, 2019
  2. changed the title [-]Add test for extending ESLint[/-] [+]Add tests for extending ESLint[/+] on Aug 13, 2019
  3. dscanlan commented on Aug 13, 2019

    @dscanlan
    Contributor

    @ianschmitz I'll take a look at this if no one else is currently looking.

  4. iansu commented on Aug 13, 2019

    @iansu
    Contributor

    @dscanlan it's all yours!

  5. kartik-budhiraja commented on Sep 15, 2019

    @kartik-budhiraja

    I would love to take this issue if you are not working on it. @dscanlan

  6. removed their assignment
    on Sep 16, 2019
  7. dscanlan commented on Sep 16, 2019

    @dscanlan
    Contributor

    Sure, @kartik-budhiraja . Sorry i've not got round to this..

  8. kushthedude commented on Sep 18, 2019

    @kushthedude

    I would love to work on it @ianschmitz

  9. ianschmitz commented on Sep 19, 2019

    @ianschmitz
    ContributorAuthor

    @kartik-budhiraja you want to work on this? Giver! If not @kushthedude can take it.

  10. kartik-budhiraja commented on Sep 19, 2019

    @kartik-budhiraja

    @ianschmitz I will work over it. Thanks!

  11. kartik-budhiraja commented on Oct 13, 2019

    @kartik-budhiraja

    @ianschmitz I created a PR #7816, it covers tests for javascript.
    For typescript, all typescript tests suits fail with this error:
    Failed to load parser '@typescript-eslint/parser declared in 'BaseConfig >> /Users/......./create-react-app/packages/eslint-config-react-app/index.js#overrides[0]': Cannot find module 'typescript'
    Can you please help me out here?

  12. danangan commented on Jul 8, 2020

    @danangan

    Hi everyone, what is the status on this issue? I would love to continue working at the existing PR if no one is looking at it right now.

  13. kartik-budhiraja commented on Jul 8, 2020

    @kartik-budhiraja

    Hey @danangan, feel free to take over the PR if you want, I am still stuck at the same issue. If you can get it solved, go for it!!

  14. sheepsteak commented on Aug 22, 2020

    @sheepsteak
    Contributor

    I've left a comment on #7816. I had a play with it and found the problem.

  15. droidMakk commented on Oct 5, 2022

    @droidMakk

    is this still relevant?

  16. 0xSaksham commented on Jul 31, 2023

    @0xSaksham

    Hey is the issue up for grabs?

  17. Aayushp2002 commented on Jan 4, 2024

    @Aayushp2002

    Hey can I still work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions