Skip to content

Updated button.md to reference Pressable instead of Touchable Opacity… - #3237

Merged
Simek merged 1 commit into
react:mainfrom
athakur3:update-button-md-with-pressable
Sep 21, 2022
Merged

Simek merged 1 commit into
react:mainfrom
athakur3:update-button-md-with-pressable

Conversation

@athakur3

@athakur3 athakur3 commented Aug 2, 2022 •

Copy link
Copy Markdown
Contributor

Updated button.md to reference Pressable instead of Touchable Opacity and TouchableWithoutFeedback

@facebook-github-bot

Copy link
Copy Markdown

Hi @athakur3!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@athakur3

athakur3 commented Aug 2, 2022

Copy link
Copy Markdown
Contributor Author

Hi @athakur3!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Signed!

@netlify

netlify Bot commented Aug 2, 2022

Copy link
Copy Markdown

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit b60270f
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/62e928f28408160009bfd37d
😎 Deploy Preview https://deploy-preview-3237--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@leotm

leotm commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

looks good @athakur3, just curious why recommend the new Pressable over TouchableOpacity or TouchableWithoutFeedback?

since TouchableOpacity or TouchableWithoutFeedback remain a simpler start
where we recommend Pressable for a more extensive approach


Capture


Capture2

@athakur3

athakur3 commented Aug 3, 2022

Copy link
Copy Markdown
Contributor Author

looks good @athakur3, just curious why recommend the new Pressable over TouchableOpacity or TouchableWithoutFeedback?

since TouchableOpacity or TouchableWithoutFeedback remain a simpler start where we recommend Pressable for a more extensive approach

Capture

Capture2

@leotm You're right in saying that it's more extensive. But, going with the "future-proof" reference, I assume that we are eventually going to migrate to Pressable API.
Hence this. Let me know if I'm wrong in my assumption.

@leotm

leotm commented Aug 3, 2022

Copy link
Copy Markdown
Contributor

gotcha ^ makes sense if that implies we're going to deprecate both, SWIM (Someone Who Isn't Me) will know

@3imed-jaberi 3imed-jaberi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 ✅

@Simek Simek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 👍


For the context, both of you have a valid points. Indeed, Pressable was created to replace all of the Touchables and Button in the long term, but because of its flexibility using Pressable requires a bit more code to be written to archive what Touchable give out-of-the box. So it's easier for the beginners to just use Touchables, without need to thinking about animation, state and interactions which need to be handled manually (this is also why we still use Touchables and Button in the docs examples way more often than Pressables).

Currently we are at the state when all components are fine to use, and there is no hard deprecation notice on the Touchables and Button yet, but this might change in the future. You can read a bit more about reasoning behind Pressable in the blog post:

@Simek
Simek merged commit 12dc712 into react:main Sep 21, 2022
@athakur3

Copy link
Copy Markdown
Contributor Author

Yay! Thanks for merging that! My first open source contribution to Meta 😄

@Simek

Simek commented Sep 21, 2022

Copy link
Copy Markdown
Collaborator

Welcome to the community! 🎉

sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Nov 7, 2022
commit 00c2808
Author: Hyungu Kang | Airen <gusrn1423@naver.com>
Date:   Sun Nov 6 21:14:16 2022 +0900

    Added lineBreakStrategyIOS to Text and TextInput (react#2566)

    Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

commit ab32e2d
Author: Robbie Plankenhorn <rplankenhorn@gmail.com>
Date:   Sun Nov 6 02:38:15 2022 -0600

    Speeding up Build: Fixing symbolic links (react#3329)

commit 8e22289
Author: Eric Edouard Amilhat <eamilhat@gmail.com>
Date:   Sat Nov 5 08:44:59 2022 +0100

    View Style Props: Add borderCurve prop (react#2785)

commit c944021
Author: Robbie <robbie@blueheart.io>
Date:   Sat Nov 5 07:41:43 2022 +0000

    Alert: Add "isPreferred" to AlertButtonStyle (react#2839)

commit f279c06
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Sat Nov 5 04:18:08 2022 -0300

    Add missing aria props to Accessibility docs (react#3396)

commit 00646cd
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Fri Nov 4 21:20:18 2022 -0300

    feat: Update fontVariant supported types docs (react#3378)

commit 96f4297
Author: khali70 <59835449+khali70@users.noreply.github.com>
Date:   Sat Nov 5 02:16:15 2022 +0200

    update to microsoft-openjdk11 (react#3386)

commit cdd9399
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Fri Nov 4 05:38:35 2022 -0300

    Fix documentation typos (react#3395)

commit ea4f803
Author: Alex Hunt <hello@alexhunt.io>
Date:   Wed Nov 2 21:07:20 2022 +0000

    Tweak homepage text to more broadly refer to platforms (react#3391)

commit 1636d5e
Author: Rafael Ricardo Vieceli <2790845+rvieceli@users.noreply.github.com>
Date:   Tue Nov 1 12:31:44 2022 +0100

    Replaced editUrl branch name with main (react#3389)

commit b47dc1d
Author: David Narbutovich <4661784+retyui@users.noreply.github.com>
Date:   Mon Oct 31 11:35:57 2022 +0100

    Recommend to use `es2019` and use community driven TS config `@tsconfig/react-native` (react#3342)

commit fd87e46
Author: Peter Cho <pcasdfj@gmail.com>
Date:   Fri Oct 28 17:54:38 2022 -0400

    Build from Source: add missing paren in publishing (react#3387)

commit d4fcb93
Author: Héctor Ramos <165856+hramos@users.noreply.github.com>
Date:   Thu Oct 27 19:38:17 2022 -0700

    The Hermes docs in next, also apply to 0.70. (react#3380)

commit 0339cae
Author: Héctor Ramos <165856+hramos@users.noreply.github.com>
Date:   Tue Oct 25 09:42:20 2022 -0700

    Add updated instructions on using Hermes (react#3376)

    * Add updated instructions on using Hermes

    * lint

commit df492ce
Author: Telmen <flyinvoke@gmail.com>
Date:   Wed Oct 19 19:20:52 2022 +0800

    Fix typo in New Architecture Intro (react#3374)

    Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

commit 262ff68
Author: mjh <61671361+mjh316@users.noreply.github.com>
Date:   Wed Oct 19 01:39:56 2022 -0700

    Fixed typo in headless-js-android.md (react#3377)

commit e4d0982
Author: Lorenzo Sciandra <lsciandra@microsoft.com>
Date:   Tue Oct 18 16:50:27 2022 +0100

    chore(release): Update release testing section for new E2E testing script (react#3368)

    * remove E2E section until we'll re-add it post E2E setup

    * remove mention of the E2E script

    * rework the release testing page

    * add mention of where to find the info to turn on new arch

    * typo

    * re-add section

commit 20908b3
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Sun Oct 16 16:45:48 2022 +0100

    New Architecture - Remove the extra steps required to copy .so files (react#3356)

commit ae47850
Author: Riccardo <cipolleschi@fb.com>
Date:   Sun Oct 16 16:45:12 2022 +0100

    fix: improve TM explanation (react#3364)

commit f042dca
Author: Bartosz Kaszubowski <gosimek@gmail.com>
Date:   Wed Oct 12 20:50:17 2022 +0200

    add back missing docs vote component (react#3371)

commit 6dc2805
Author: Luis Medina <luism3861@gmail.com>
Date:   Wed Oct 12 03:19:27 2022 -0500

    docs: update running on simulator iOS (react#3346)

commit 3add39c
Author: Karl Horky <karl.horky@gmail.com>
Date:   Wed Oct 12 10:16:55 2022 +0200

    Getting Started: list zsh before bash in macOS guide (react#3358)

    Co-authored-by: Nicola Corti <corti.nico@gmail.com>

commit f6be947
Author: Chukwu Smart <chukwusmartchukwuemeka@gmail.com>
Date:   Wed Oct 12 09:14:23 2022 +0100

    ScrollView: rephrase onContentSizeChange description (react#3357)

    Co-authored-by: Nicola Corti <corti.nico@gmail.com>

commit 37d85ba
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Wed Oct 12 05:11:14 2022 -0300

    Layout Props: Update aspectRatio supported types (react#3363)

commit e00c9b0
Author: Jesse Katsumata <jesse.katsumata@gmail.com>
Date:   Wed Oct 12 17:07:36 2022 +0900

    Getting Started: fix Android version label in older docs (react#3367)

commit 03d8848
Author: Timothy Yung <yungsters@meta.com>
Date:   Tue Oct 11 15:15:08 2022 -0700

    Fix headers on *.ts files (react#3370)

commit e5ba872
Author: Timothy Yung <yungsters@meta.com>
Date:   Tue Oct 11 15:07:00 2022 -0700

    Missing header in `docusaurus.config.js` (react#3369)

commit f0d9c4a
Author: Jesse Katsumata <jesse.katsumata@gmail.com>
Date:   Sat Oct 8 05:45:16 2022 +0900

    Communities: remove duplicate header (react#3365)

commit a6e7419
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Thu Oct 6 06:45:52 2022 -0300

    feat: Add verticalAlign to Text Style Props docs (react#3361)

commit 911a282
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Wed Oct 5 11:15:01 2022 +0100

    Finalize the Kotlinization (react#3360)

    * Finalize the Kotlinization

    * Remove extra imports

commit 3c124e0
Author: Asaf Korem <55082339+asafkorem@users.noreply.github.com>
Date:   Tue Oct 4 21:03:42 2022 +0300

    Showcase: add Wix's apps section. (react#3349)

commit 2e4eb04
Author: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>
Date:   Tue Oct 4 13:09:33 2022 +0200

    Fix codegen iOS scripts paths (react#3359)

commit 4c3603b
Author: Ismael Moreira <ismaelsousa1998@outlook.com>
Date:   Mon Oct 3 14:09:54 2022 -0300

    Update pillars-turbomodule.md (react#3355)

commit 4b1aeff
Author: Oskar Kwaśniewski <oskarkwasniewski@icloud.com>
Date:   Mon Oct 3 15:58:05 2022 +0200

    fix: remove isTurboModuleEnabled check from docs (react#3337)

    * fix: remove isTurboModuleEnabled check

    * fix: remove unnecessary back ticks

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>

commit 9987b07
Author: Timothy Yung <yungsters@meta.com>
Date:   Fri Sep 30 08:43:45 2022 -0700

    Fix more copyright header issues (react#3353)

commit 84397da
Author: Timothy Yung <yungsters@meta.com>
Date:   Fri Sep 30 08:43:28 2022 -0700

    Update to Contributor Covenant (react#3354)

commit 6e981dd
Author: Lorenzo Sciandra <lsciandra@microsoft.com>
Date:   Fri Sep 30 11:57:11 2022 +0100

    rework the community section of the website (react#3338)

    Co-authored-by: Luna <lunaleaps@gmail.com>

commit b943d45
Author: Timothy Yung <yungsters@fb.com>
Date:   Fri Sep 30 00:49:39 2022 -0700

    Apply updated copyright to `*.js` files (react#3352)

commit 006f573
Author: Timothy Yung <yungsters@fb.com>
Date:   Fri Sep 30 00:48:43 2022 -0700

    Address Security Vulnerabilities in Dependencies (react#3351)

commit d6fe39d
Author: Arati Chilad <58401542+arati-1@users.noreply.github.com>
Date:   Wed Sep 28 03:43:38 2022 -0700

    Checks for the documentation (react#3348)

commit 3d1ea2c
Author: Lorenzo Sciandra <lsciandra@microsoft.com>
Date:   Tue Sep 27 17:27:34 2022 +0100

    add NFL to the showcase (react#3347)

commit ff9886c
Author: Pavlos Vinieratos <pvinis@gmail.com>
Date:   Mon Sep 26 12:44:01 2022 +0300

    Update showcase link for Artsy (react#3340)

commit 905824a
Author: Joshua Yoes <37849890+joshuayoes@users.noreply.github.com>
Date:   Mon Sep 26 01:17:31 2022 -0700

    fix(native-modules-android.md): rename createCalendarEventCallback (react#3345)

commit 400d509
Author: Damoness <qjwdcool@qq.com>
Date:   Mon Sep 26 15:54:57 2022 +0800

    Layout Props: clean warning in example (react#3344)

commit 86139c5
Author: David Narbutovich <4661784+retyui@users.noreply.github.com>
Date:   Sun Sep 25 21:14:53 2022 +0400

    Document ability to pass Element via ItemSeparatorComponent (react#3343)

commit c9448b0
Author: Daksh Bhardwaj <dakshbhardwaj2@gmail.com>
Date:   Fri Sep 23 14:33:41 2022 +0530

    add documentation for `aria-valuemax` `aria-valuemin` `aria-valuenow` `aria-valuetext` (react#3318)

commit 54f9a7d
Author: Connor Tumbleson <iBotPeaches@users.noreply.github.com>
Date:   Fri Sep 23 03:02:12 2022 -0400

    Add Source Maps Page (react#3293)

    Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
    Co-authored-by: Dmytro Rykun <dmitry.rykun@gmail.com>

commit 69f723b
Author: Daksh Bhardwaj <dakshbhardwaj2@gmail.com>
Date:   Fri Sep 23 12:29:47 2022 +0530

    Text: add documentation for `userSelect` prop (react#3311)

commit 4260478
Author: Daksh Bhardwaj <dakshbhardwaj2@gmail.com>
Date:   Fri Sep 23 12:25:51 2022 +0530

    add documentation for `aria-modal` prop (react#3320)

commit 94c5e80
Author: Oskar Kwaśniewski <oskarkwasniewski@icloud.com>
Date:   Thu Sep 22 14:46:19 2022 +0200

    fix: remove isFabricEnabled check from docs (react#3336)

    * fix: remove isFabricEnabled check

    * fix: language lint

commit b55bdc6
Author: Dhruv Tailor <32268377+dhruvtailor7@users.noreply.github.com>
Date:   Thu Sep 22 18:15:06 2022 +0530

    Add new props to Image docs (react#3310)

commit 357254c
Author: Lorenzo Sciandra <lsciandra@microsoft.com>
Date:   Thu Sep 22 11:32:05 2022 +0100

    chore: clean up new arch docs (react#3332)

    * tweaks

    * revert change

commit 12dc712
Author: Akshansh Thakur <aksh500@gmail.com>
Date:   Wed Sep 21 23:18:21 2022 +0530

    Updated button.md to reference Pressable (react#3237)

commit 8754483
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Wed Sep 21 09:47:51 2022 -0300

    Add id prop to Text, TouchableWithoutFeedback and View docs (react#3285)

commit 91ce6bc
Author: Riccardo <cipolleschi@fb.com>
Date:   Wed Sep 21 12:52:34 2022 +0100

    fix: Improve wording for iOS getting started (react#3334)

commit b5f5b5a
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Wed Sep 21 08:23:41 2022 -0300

    Update colors docs regarding expanded support for CSS Colors (react#3306)

commit 4e386d6
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Wed Sep 21 11:41:31 2022 +0100

    Update docs with AGP 7.3.x setup (react#3333)

commit 72c8bd5
Author: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
Date:   Tue Sep 20 18:34:32 2022 +0100

    Modify the top navbar to be less full (react#3177)

    * modify navbar

    * rename

    * reorder and rename

    * reorder the navbar

    * change size to match the other elements

    * change style to match the other elements

    * tweak the footer to reflect the new header

    * fix link

    * fix the other link

    * small CSS tweaks

    * small naming tweak

    Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

commit 7202412
Author: Bartosz Kaszubowski <gosimek@gmail.com>
Date:   Tue Sep 20 00:35:29 2022 +0200

    fix incorrect link to re-enable prod deploy (react#3330)

commit 5dd8fcd
Author: Lorenzo Sciandra <lorenzo.sciandra@gmail.com>
Date:   Fri Sep 16 18:27:40 2022 +0100

    showcase: update entries (react#3328)

commit 8c65a42
Author: Lorenzo Sciandra <lsciandra@microsoft.com>
Date:   Fri Sep 16 11:19:11 2022 +0100

    minor tweaks to the wording for the versions page (react#3327)

commit 7bb5d88
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Fri Sep 16 12:00:23 2022 +0300

    [0.71.0] Update the New Architecture guide with the changes for the New Template on Android (react#3324)

    Co-authored-by: Riccardo <cipolleschi@fb.com>

commit 5462afb
Author: Sunny Luo <sunnylqm@gmail.com>
Date:   Fri Sep 16 16:04:34 2022 +0800

    fix _getting-started-macos-ios.md info format (react#3326)

commit a917b04
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Thu Sep 15 14:54:20 2022 +0300

    Fix broken links to Appendix (react#3319)

commit 1285a79
Author: Riccardo <cipolleschi@fb.com>
Date:   Thu Sep 15 11:21:03 2022 +0200

    [Fix] Improve Getting started with iOS (react#3323)

commit 791d9d1
Author: Riccardo <cipolleschi@fb.com>
Date:   Wed Sep 14 10:39:08 2022 +0200

    [FEAT] Add doc to simplify podspecs for Native Modules and Native Components (react#3321)

    * [FEAT] Add doc to simplify podspecs for Native Modules and Native Components

    * fix: apply suggested changes I

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

    * fix: apply suggested changes II

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

    * fix: apply suggested changes III

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

    * fix: apply suggested changes IV

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

    * fix: apply suggested changes V

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

    * fix: apply suggested changes VI

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

    Co-authored-by: Arati Chilad <58401542+arati-1@users.noreply.github.com>

commit 0468011
Author: JiashengWu <wujs1010@outlook.com>
Date:   Wed Sep 14 00:19:07 2022 -0700

    Fix title case in testing-overview.md (react#3322)

commit 38cd75a
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Tue Sep 13 19:24:25 2022 +0100

    Remove unnecessary box from Legacy Native Modules/Components (react#3313)

commit bbd36d1
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Fri Sep 9 21:18:24 2022 +0100

    [0.70] Clarify New Architecture Terminology (react#3315)

commit c084b5a
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Fri Sep 9 21:18:04 2022 +0100

    Clarify New Architecture Terminology - Take 2 (react#3316)

commit 63d00e7
Author: Ricky <rickhanlonii@gmail.com>
Date:   Fri Sep 9 15:13:35 2022 -0400

    Revert "Clarify New Architecture Terminology (react#3308)" (react#3314)

    This reverts commit 54d266b.

commit 54d266b
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Fri Sep 9 15:08:43 2022 +0100

    Clarify New Architecture Terminology (react#3308)

commit 42e0266
Author: Riccardo <cipolleschi@fb.com>
Date:   Fri Sep 9 12:21:24 2022 +0100

    fix: Address missing feedback from prev PR (react#3312)

commit 4a3b02c
Author: Riccardo <cipolleschi@fb.com>
Date:   Fri Sep 9 12:03:13 2022 +0100

    [New Architecture][iOS][0.71.0] Update the App Migration section (react#3268)

commit 7c1091c
Author: Arati Chilad <58401542+arati-1@users.noreply.github.com>
Date:   Thu Sep 8 09:19:13 2022 -0700

    The New Architecture section editorial review  (react#3288)

    * [Do Not Merge] Refactoring The New Architecture (react#3029)

    * [Guide - The New Architecture] What Backward Compatibility Is (react#3038)

    * Guide to creating a New Architecture app from template (react#3056)

    * Start new template guide

    This is a first iteration. I want to get feedback on a few aspects, so
    starting from here as a baseline.

    * Update title

    * Use tabs for target OS

    Set up matching the style of "Getting Started", except I kept the
    headers inside the tabs for now as it makes for a useful right-hand TOC.

    * Capitalize New Architecture, simplify

    * Preliminary section for Hermes

    Add section for recommending enabling Hermes. Not sure of contents yet,
    and still have to test.

    * Reword to emphasize importance of Hermes usage

    * Show new arch in use

    * Add build speed article link

    * Add pro tip for pod install alias

    * Restructure, repeat less

    Favor linking to original setup guide instead of repeating content.

    * Note about Expo

    * Include command on uninstalling global CLI

    * How to learn more

    * Remove headers in tabs

    They don't work correctly with the righthand TOC.

    * Make header more clear

    * Use quote block less often

    There was way too much yellow.

    * Opt for instructions using XCode

    Because `xcodebuild clean` already failed me once when XCode GUI clean
    worked.

    * Fix lint issue

    * Improve wording

    * Use product name

    * Fix line wraps

    * Reword based on feedback

    * Note use of bundle install

    * Pod removal instructions

    Also standardize on using yarn scripts from template for commands, it's
    a little confusing to see the mix of `npx` and `yarn` once we start
    referring to `yarn pod-install`

    * Convert quotes to admonitions

    * Convert Note: to admonitions

    * Feedback: Change admonitions to caution

    * PR feedback

    * New Architecture landing page (react#3072)

    * First draft of landing page

    * Add migration and backwards compatibility links

    * lint fix

    * Restructure slightly, leaning more on context from Why a New Architecture

    * Don't need md in links

    * Suggested rewording

    * Rephrase pillar summaries

    * [Guide - The New Architecture] Why A New Architecture (react#3043)

    * [Guide - The New Architecture] Pillars (react#3046)

    * [Guide - The New Architecture] TurboModules as Native Modules (react#3039)

    * [Guide - The New Architecture] Fabric Components as Native Components (react#3040)

    * [FEAT][TNA] Fabric Component Guide (react#3132)

    * [Feat] Add intro for Fabric Components

    * feat: add guide to create a Fabric Component

    * Add page on codegen (react#3155)

    * [FEAT] TurboModules guide (react#3168)

    * [Feat] Add intro for Fabric Components

    * feat: add guide to create a Fabric Component

    * Beginning of guide/folder structure

    * WIP JS Spec

    * specification section

    * Configuration

    * native code intro

    * Must be named Spec

    * Best stab at iOS native code, but I don't know how to describe what's going on in the code very well. Extrapolated what I could.

    * Android instructions

    iOS isn't working for me. Builds, but can't load module.

    Writing up Android auto-linking next because the steps I tested did
    work.

    * Include linking instructions from RNNArch repo

    * Add example JavaScript

    * native modules link

    * Address quick feedback items

    * Remove, fix for rebased branch

    * fix TM parameter on Android

    * Revert to 'Codegen' casing

    * Revert folly version change

    2021.07.22 is for current version on main

    * fix typo

    * getTurboModule explainer

    * Sentence edits

    - Fix acronym bolding
    - Change wording to "recommended" because "standard" has other
      connotations of possibly being required
    - Parentheses unnecessary, distracting

    * Remove TODO for now

    Getting inconsistent results here, not sure if this is wrong or not;
    removing TODO for now so it doesn't block anything

    * ABI rephrase, more in line with new Fabric guide wording

    * Explain shared C++ code more

    * feat: add guide to create a Fabric Component

    * feat: add guide to create a Fabric Component

    * package.json description

    * Lint fixes

    * fix: Move JS constants to reduce changes

    * fix: Remove newline

    * feat: add required step for Android Codegen

    * fix: use the proper links

    Co-authored-by: Riccardo Cipolleschi <cipolleschi@fb.com>

    * wip: migration guide review (react#3200)

    * Fix for some typos and other editorial related changes

    * Update docs/the-new-architecture/pillars-fabric-components.md

    correcting the article

    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>

    * Update pillars-fabric-components.md

    Co-authored-by: Riccardo <cipolleschi@fb.com>
    Co-authored-by: Lizzi Lindboe <lindboe@users.noreply.github.com>
    Co-authored-by: Riccardo <riccardo.cipolleschi@gmail.com>

commit 9e6e311
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Thu Sep 8 12:55:43 2022 +0100

    Follow-up on CMake clarification for 0.70 (react#3309)

commit 000d581
Author: Nicola Corti <corti.nico@gmail.com>
Date:   Thu Sep 8 09:49:49 2022 +0100

    Update New Architecture instructions to use CMake instead of Android.mk (react#3304)

commit d9d4adb
Author: Vojtech Novak <vonovak@gmail.com>
Date:   Wed Sep 7 09:08:34 2022 +0200

    docs: fix path in script example (react#3302)

commit 10f26e9
Author: Ricky <rickhanlonii@fb.com>
Date:   Tue Sep 6 13:00:59 2022 -0400

    Revert renaming native components (react#3301)

commit b432092
Author: Daksh Bhardwaj <daksh@plgworks.com>
Date:   Tue Sep 6 19:31:59 2022 +0530

    TextInput: Add enterKeyHint prop (react#3299)

commit f57ac2d
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Tue Sep 6 09:36:40 2022 -0300

    Image: Add tintColor prop (react#3292)

    Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

commit 7d7f483
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Tue Sep 6 09:35:28 2022 -0300

    View: Add tabIndex prop (react#3286)

    Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>

commit 9422060
Author: fabriziobertoglio1987 <fabrizio.bertoglio@gmail.com>
Date:   Tue Sep 6 17:29:42 2022 +0800

    adding accessibilityRole 'grid' to documentation (react#3224)

commit 0de9633
Author: EvertEt <evert.etienne@gmail.com>
Date:   Tue Sep 6 11:22:19 2022 +0200

    Flexbox: correct example description (react#3284)

commit 04250d6
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Tue Sep 6 06:18:34 2022 -0300

    TextInput: Add inputMode prop (react#3289)

commit 9a4ad7a
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Tue Sep 6 06:08:25 2022 -0300

    TextInput: Add rows prop (react#3280)

commit 51a7543
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Tue Sep 6 06:04:49 2022 -0300

    AccessibilityInfo: add prefersCrossFadeTransitions to docs (react#3279)

commit 010d7cd
Author: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
Date:   Tue Sep 6 06:02:01 2022 -0300

    TextInput: Add readOnly prop (react#3278)
sunnylqm added a commit to reactnativecn/react-native-website that referenced this pull request Nov 7, 2022