Repository navigation
[0.32.1] Commits to cherry pick into stable release #9431
Description
Activity
FYI we've bunch of regressions in latest release - https://github.com/facebook/react-native/issues?q=is%3Aissue+is%3Aopen+label%3ARegression
Reacted by Martin Konicek and Jake Murzy- added a commit that references this issue
on Aug 16, 2016 I haven't seen it mentioned yet, but I'm noticing big problems with image loading and caching in 0.32. In fact it seems like images are not cached at all, resulting in super slow image load times (especially for repeated images like avatars). It prompted me to look through the commit history, and the large image cache refactor could be the culprit: ddc70ff
Should I create a separate issue or is there already something out there covering it?
Reacted by Basil Siddiqui@sjmueller, please raise a separate issue with a video example if you can and cc people related to the change.
Also cc me, I'll link it internally.Nothing explicitly listed so will release w/o cherry-picks.
It's not yet deployed so it's up to you. Just let me know so I'll update interested ppl via twitter :)
Hey all, apologies for the delay regarding image cache / decoding issues. Would you still like me to submit an issue, or did your internal investigation yield the same findings?
Yes Sam, please submit one.
Also if you could help investigating it would be much appreciatedOn Tuesday, 23 August 2016, Sam Mueller notifications@github.com wrote:
Hey all, apologies for the delay regarding image cache / decoding issues.
Would you still like me to submit an issue, or did your internal
investigation yield the same findings?—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#9431 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWOmCUzW96uiyufHiW4W25zb8sJ_0ks5qiqajgaJpZM4JlRQa
.@sjmueller I've noticed that issue too, when i preview the loaded image, the image is loaded again, seems the cache doesn't work, I'm using RN0.32RC0
Could someone provide some repro instructions for the caching issue? Does this happen on iOS or Android? What are example image URLs that are not cached?
Also
bring back android commandcommit should be cherry-picked before we ship tomorrow morning.@javache @bestander @sjmueller shall we move to a separate issue so the cherry-pick thread is not polluted with unrelated comments?
shall we move to a separate issue
Yes, is there an issue for the image caching? If not just create one :) ddc70ff looks like it might be related, good find @sjmueller! And yeah, we need a repro :) Have more people seen images never being cached? This is only on iOS, correct?
Yes, we should definitely
On Wednesday, 24 August 2016, Mike Grabowski notifications@github.com
wrote:Also bring back android command from rnpm - in the morning.
@javache https://github.com/javache @bestander
https://github.com/bestander @sjmueller https://github.com/sjmueller
shall we move to a separate issue so the cherry-pick thread is not polluted
with unrelated comments?—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9431 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACBdWK_Z-Z0dl9wPchY06lh4rmoFkZjbks5qjH7KgaJpZM4JlRQa
.To pick into 0.32.1
- Include CSSLayout.h consistently with other project includes #9544 CocoaPods + css-layout
- [0.32] Image caching broken #9581 - image caching bug
@alloy looks like it's not yet merged, but I'll do as a 0.32.1 as @bestander suggested.
Reacted by Eloy Durán, Rob Hogan, Satyajit Sahoo and Tianyu Yao- changed the title
[-][0.32] Commits to cherry pick into stable release[/-][+][0.32.1] Commits to cherry pick into stable release[/+]on Aug 25, 2016 I concor
- locked as resolved and limited conversation to collaborators
on May 24, 2018