Skip to content

Android O Support [DON'T MERGE] - #13222

Closed
AndrewJack wants to merge 1 commit into
react:masterfrom
AndrewJack:androido
Closed

AndrewJack wants to merge 1 commit into
react:masterfrom
AndrewJack:androido

Conversation

@AndrewJack

Copy link
Copy Markdown
Contributor

Motivation

Add support for apps targeting Android O.

Note: I am not expecting this to be merged into a release. This is just to provide visibility, and to inform people what they need to change to test Android O.

What's changed?

In upcoming Android O the window type has changed from TYPE_SYSTEM_ALERT to TYPE_APPLICATION_OVERLAY.
https://developer.android.com/preview/behavior-changes.html#cwt

To check if we are using the O preview I am using this check "O".equals(Build.VERSION.CODENAME)
As suggested here https://commonsware.com/blog/2015/06/05/supporting-m-developer-preview-previous-versions.html

Test Plan (required)

Try my sample project https://github.com/AndrewJack/react-native-android-o

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. GH Review: review-needed labels Mar 30, 2017
@AndrewJack AndrewJack closed this Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants