Expose box sizing getters and setters in Yoga - #1701
Closed
joevilches wants to merge 1 commit into
Closed
joevilches wants to merge 1 commit into
joevilches wants to merge 1 commit into
Conversation
Summary: I would like to write some tests for box sizing that will drive a lot of my development as I implement content box. To do that, I need this publicly exposed. Obviously not that ideal since this currently does not do anything. Maybe we can name the value in such a way that its clear it is in development? Reviewed By: NickGerleman Differential Revision: D63135970
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63135970 |
Contributor
|
This pull request has been merged in 43d920e. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 25, 2024
Summary: X-link: react/yoga#1701 X-link: react/react-native#46630 I would like to write some tests for box sizing that will drive a lot of my development as I implement content box. To do that, I need this publicly exposed. Obviously not that ideal since this currently does not do anything. Maybe we can name the value in such a way that its clear it is in development? Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63135970 fbshipit-source-id: 7520823bf925364eae45341531e012e80ec92284
facebook-github-bot
pushed a commit
to react/react-native
that referenced
this pull request
Sep 25, 2024
Summary: X-link: react/yoga#1701 Pull Request resolved: #46630 I would like to write some tests for box sizing that will drive a lot of my development as I implement content box. To do that, I need this publicly exposed. Obviously not that ideal since this currently does not do anything. Maybe we can name the value in such a way that its clear it is in development? Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D63135970 fbshipit-source-id: 7520823bf925364eae45341531e012e80ec92284
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: I would like to write some tests for box sizing that will drive a lot of my development as I implement content box. To do that, I need this publicly exposed. Obviously not that ideal since this currently does not do anything. Maybe we can name the value in such a way that its clear it is in development?
Reviewed By: NickGerleman
Differential Revision: D63135970