[Pratik-Redhat-Tech]

What does this PR do?

Removes unused hack/non-olm-install (installer script, README, and RBAC patch). That installer is unused and was confusing contributors; #1287 asks to delete it rather than fix it.

Fixes #1287

NON_OLM=true e2e skips for a plain Deployment install are unchanged. Those live under test/openshift/e2e/ and are not this installer.

PR acceptance criteria:

• Documentation was updated and verified using make serve-docs OR not applicable (the only docs for this path lived in hack/non-olm-install/README.md, which is removed with the unused installer)
• Unit tests were updated OR not applicable (no product / Go code change)
• E2E tests were updated OR not applicable (e2e NON_OLM skips are a separate test fixture)

What type of PR is this?

/kind cleanup

How I validated

From the branch root:

test ! -d hack/non-olm-install && echo PASS: installer dir gone

rg -n 'hack/non-olm-install' || echo PASS: no remaining path refs

rg -n 'func EnvNonOLM' test/openshift/e2e/ginkgo/fixture/fixture.go

Results:

• hack/non-olm-install is gone (README, install-gitops-operator.sh, rbac-patch.yaml)
• no remaining hack/non-olm-install references
• EnvNonOLM() is still in the e2e fixture

No go test / e2e change: this is a directory delete only.

How to reproduce (reviewer)

git fetch origin pull/1442/head:pr-1442
git checkout pr-1442
test ! -d hack/non-olm-install
rg -n 'hack/non-olm-install' || true
ls hack/non-olm-install 2>&1 | cat

On master the directory exists; on this branch it does not. Product install path is still OLM (make bundle / OperatorHub), unchanged.

Special notes to the reviewer:

Watch that only hack/non-olm-install/ is removed. Do not drop NON_OLM e2e skips.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @Pratik-Redhat-Tech. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: redhat-developer/gitops-operator
• Branch: master
• File: .coderabbit.yaml
• Commit: e6f56d0
• Layers: Repository YAML (base), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 786f73c2-5bdd-4f44-94dd-7ea0eec5b891

📥 Commits

Reviewing files that changed from the base of the PR and between 0225efb and 3fd055a.

📒 Files selected for processing: 1

• hack/non-olm-install/README.md

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

💤 Files with no reviewable changes: 1

• hack/non-olm-install/README.md

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Summary

Summary by CodeRabbit

• Chores
  • Removed the non-OLM installation utility, including its install, uninstall, and migration workflows.
  • Removed the associated RBAC patch configuration.
• Documentation
  • Removed the non-OLM installation guide, including setup prerequisites, configuration instructions, and workflow examples. Details on updates, migrations, known RBAC issues, and troubleshooting are no longer included in the repository’s documentation.

The non-OLM installer script, RBAC patch, and README were deleted. The removed files covered installation, uninstallation, and OLM migration workflows.

Changes: Non-OLM installation tooling removal

Layer / File(s)	Summary
Remove installer and supporting assets hack/non-olm-install/install-gitops-operator.sh, hack/non-olm-install/rbac-patch.yaml, hack/non-olm-install/README.md	The installer script, RBAC patch, and documentation for non-OLM installation and migration were deleted.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 3fd05

The deleted installer is not required by the checked-in workflows, so the change is ready to merge after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely identifies the removal of the unused hack/non-olm-install directory, which is the main change.
Description check		The description accurately explains the deleted installer files, confirms that NON_OLM e2e skips remain unchanged, and documents validation steps.
Linked Issues check		Issue #1287 requests deletion of the unused hack/non-olm-install/ directory. The whole-PR summary shows deletion of its README.md, install-gitops-operator.sh, and rbac-patch.yaml. These change…
Out of Scope Changes check		The reviewed changes delete only the three files under hack/non-olm-install/. The deletion directly supports issue #1287. The summary shows no unrelated product, test, e2e, or documentation changes.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Full details: Linked Issues check

Explanation

Issue #1287 requests deletion of the unused hack/non-olm-install/ directory. The whole-PR summary shows deletion of its README.md, install-gitops-operator.sh, and rbac-patch.yaml. These changes implement the issue objective. No additional coding requirement is specified.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

_{Comment @coderabbitai help to get the list of available commands.}

[olivergondza]

/ok-to-test

To be sure these are not referenced somewhere in the depth of CI...

[olivergondza]

@Pratik-Redhat-Tech, please resolve conflict

[olivergondza]

@Pratik-Redhat-Tech, please resolve conflict

[Pratik-Redhat-Tech]

Rebased onto current master. The conflict was hack/non-olm-install/README.md (modified on master, deleted in this PR); kept the deletion so the unused installer is fully removed.

[Pratik-Redhat-Tech]

@olivergondza Conflict resolved as you asked. Rebased onto current master. The clash was hack/non-olm-install/README.md (updated on master, deleted in this PR); kept the deletion so the unused installer is fully gone. CI is running.