Add suppport for cpuLimit, cpuRequest and memoryRequest by anandrkskd · Pull Request #5252 · redhat-developer/odo

anandrkskd · 2021-11-25T20:17:46Z

What type of PR is this?
/kind feature

What does this PR do / why we need it:
This PR adds feature to add cpuLimit, cpuRequest and memoryRequest values using devfile for a container
Which issue(s) this PR fixes:

Fixes #5132

PR acceptance criteria:

Unit test
Integration test
Documentation
I have read the test guidelines

How to test changes / Special notes to the reviewer:

 git clone https://github.com/openshift/nodejs-ex ; cd nodejs-ex
odo create nodejs --devfile ~/go/src/github.com/openshift/odo/tests/examples/source/devfiles/nodejs/devfile-with-MR-CL-CR.yaml
odo push
oc get pods podname -o jsonpath='{.spec.containers[0].resources}{"\n"}'

netlify · 2021-11-25T20:19:22Z

✔️ Deploy Preview for odo-docusaurus-preview canceled.

🔨 Explore the source changes: aa90334

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/61b05f24124afd00077a6329

feloy · 2021-11-26T08:36:57Z

@anandrkskd during the integration tests, we get the following errors:

[odo]  ✗  failed to parse the devfile /tmp/133431546/devfile.yaml, with error: invalid devfile schema. errors :
[odo] - components.2.volume: Additional property ephemeral is not allowed

It seems a problem similar to devfile/api#675

feloy · 2021-11-30T09:40:46Z

@anandrkskd , by downgrading to a previous commit of devfile/library, it seems that your PR will work.
You can try:

go get github.com/devfile/library@ab7bd9b8b615d75dbe99c414bd8d80f51894699d
go mod vendor

This is a commit just after the introduction of the new limits/requests, and before the change about the problematic ephemeral field. It is also before the changes of the GetRoute and GetIngress functions signatures, you will have to revert these changes.

anandrkskd · 2021-11-30T09:42:49Z

Understood, will give it try ASAP.
Thanks, @feloy

sonarqubecloud · 2021-11-30T10:26:53Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
38.8% Duplication

anandrkskd · 2021-11-30T11:22:50Z

/test psi-kubernetes-integration-e2e

valaparthvi · 2021-12-01T06:45:03Z

Can you also take a look at the Sonar Cloud duplication report?

feloy · 2021-12-01T17:21:54Z

Kubernetes Tests finished.
View logs: TXT HTML

feloy · 2021-12-01T17:35:01Z

Unit Tests finished.
View logs: TXT HTML

feloy · 2021-12-01T17:55:31Z

Kubernetes Tests finished.
View logs: TXT HTML

feloy · 2021-12-01T18:09:29Z

OpenShift Tests finished.
View logs: TXT HTML

feloy · 2021-12-01T18:19:40Z

Unit Tests finished.
View logs: TXT HTML

anandrkskd · 2021-12-02T05:07:53Z

@feloy @valaparthvi can we move forward with lgtm and approve?

valaparthvi

Sorry about the nitty-gritty changes, but these are last few 🤞

valaparthvi · 2021-12-02T07:16:23Z

Thank you for the changes!
/approve

feloy · 2021-12-02T07:35:36Z

Kubernetes Tests finished.
View logs: TXT HTML

feloy · 2021-12-02T07:46:11Z

OpenShift Tests finished.
View logs: TXT HTML

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

feloy · 2021-12-08T06:59:31Z

Kubernetes Tests finished.
View logs: TXT HTML

feloy · 2021-12-08T07:01:54Z

OpenShift Tests finished.
View logs: TXT HTML

feloy · 2021-12-08T07:15:43Z

Unit Tests finished.
View logs: TXT HTML

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

feloy · 2021-12-08T07:47:59Z

Kubernetes Tests finished.
View logs: TXT HTML

feloy · 2021-12-08T07:53:32Z

Unit Tests finished.
View logs: TXT HTML

feloy · 2021-12-08T07:56:57Z

OpenShift Tests finished.
View logs: TXT HTML

feloy · 2021-12-08T08:44:02Z

/lgtm

Thanks for this work @anandrkskd

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Nov 25, 2021

openshift-ci Bot requested review from feloy and valaparthvi November 25, 2021 20:18

anandrkskd force-pushed the dev/update-devfile-api-2.1.0 branch from 5411f00 to 15c8e2e Compare November 25, 2021 20:26

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Nov 25, 2021

anandrkskd changed the title ~~Dev/update devfile api 2.1.0~~ Add suppport for cpuLimit, cpuRequest and memoryRequest Nov 26, 2021

feloy mentioned this pull request Nov 26, 2021

Validation fails on devfile 2.0.0 with unknown ephemeral field on volume devfile/api#697

Closed

valaparthvi suggested changes Dec 1, 2021

View reviewed changes

Comment thread tests/integration/devfile/cmd_devfile_push_test.go Outdated

Comment thread tests/integration/devfile/cmd_devfile_push_test.go Outdated

Comment thread tests/integration/devfile/cmd_devfile_push_test.go

Comment thread tests/integration/devfile/cmd_devfile_push_test.go Outdated

openshift-ci Bot assigned valaparthvi Dec 1, 2021

anandrkskd requested a review from valaparthvi December 1, 2021 16:54

feloy suggested changes Dec 1, 2021

View reviewed changes

Comment thread tests/integration/devfile/cmd_devfile_push_test.go Outdated

anandrkskd requested a review from feloy December 1, 2021 18:28

valaparthvi suggested changes Dec 2, 2021

View reviewed changes

Comment thread tests/integration/devfile/cmd_devfile_push_test.go Outdated

Comment thread tests/integration/devfile/cmd_devfile_push_test.go

Comment thread tests/integration/devfile/cmd_devfile_push_test.go

valaparthvi approved these changes Dec 2, 2021

View reviewed changes

openshift-ci Bot assigned feloy Dec 2, 2021

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Dec 6, 2021

anandrkskd added 12 commits December 8, 2021 12:03

update Devfile library and api

8f2b04d

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

resolve problem occured by update

5706524

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

add test for cpuLimit,cpuRequest,memoryRequest

6619e0e

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

resolve branch conflicts

f52671e

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

update schema version to 2.2.0 for test devfiles

11fe55b

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

revert - update schema version to 2.2.0 for test devfiles

3b3d784

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

downgrade devfile library

8c170a8

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

update test, remove duplication

eb6c29a

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

replace oc with kubectl

e524467

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

restructure when

6742204

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

force push

e403f8c

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

rebase and update the test to use cliRunner

e333156

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

anandrkskd force-pushed the dev/update-devfile-api-2.1.0 branch from 0dce90c to e333156 Compare December 8, 2021 06:53

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Dec 8, 2021

anandrkskd requested review from feloy and valaparthvi December 8, 2021 06:54

remove golint issues

aa90334

Signed-off-by: anandrkskd <anandrkskd@gmail.com>

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 8, 2021

openshift-merge-robot merged commit 0e42e99 into redhat-developer:main Dec 8, 2021

dharmit added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Dec 21, 2021

anandrkskd deleted the dev/update-devfile-api-2.1.0 branch October 13, 2022 11:10

Conversation

anandrkskd commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Nov 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feloy commented Nov 26, 2021

Uh oh!

feloy commented Nov 30, 2021

Uh oh!

anandrkskd commented Nov 30, 2021

Uh oh!

sonarqubecloud Bot commented Nov 30, 2021

Uh oh!

anandrkskd commented Nov 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valaparthvi commented Dec 1, 2021

Uh oh!

feloy commented Dec 1, 2021

Uh oh!

Uh oh!

feloy commented Dec 1, 2021

Uh oh!

feloy commented Dec 1, 2021

Uh oh!

feloy commented Dec 1, 2021

Uh oh!

feloy commented Dec 1, 2021

Uh oh!

anandrkskd commented Dec 2, 2021

Uh oh!

valaparthvi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valaparthvi commented Dec 2, 2021

Uh oh!

feloy commented Dec 2, 2021

Uh oh!

feloy commented Dec 2, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

feloy commented Dec 8, 2021

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anandrkskd commented Nov 25, 2021 •

edited

Loading

netlify Bot commented Nov 25, 2021 •

edited

Loading