This repository was archived by the owner on Oct 4, 2026. It is now read-only.
Repository navigation
typescript: restore ambient @types for tsgo with the types wildcard - #22
Merged
Merged
Conversation
TypeScript 7 loads no @types implicitly. The generated tsconfig now opts back in with types ["*"] plus typeRoots at the staged tree, and stage-nm skips @types entries whose repos were never materialized (npm-metadata- only deps) since the wildcard silently ignores an absent entry but errors on a non-package directory. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XfbNYjsVdoA495rijfFpPt
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript 7 loads no ambient Types (@types) implicitly, which breaks every declaration compile relying on globals from node_modules/Types (@types) (Buffer, process, Temporal, ...). The generated tsconfig now opts back in with TypeScript's compat mechanism — "types": ["*"] plus typeRoots at the staged tree — scoped to exactly what stage-nm stages. stage-nm skips Types (@types) entries whose repos were never materialized (npm-metadata-only deps like cosmiconfig -> @types/parse-json, and bare-index.d.ts workspace packages like @types/suitescript are kept): the wildcard silently ignores an absent entry, matching the old implicit behavior, but errors on a non-package directory. The lint tsconfig (--no-preserve-symlinks) is deliberately unchanged. dist/ regenerated with //typescript/config:gen. Consumed by redo MR redo/redoapp/product/redo!62221 via RULES_JAVASCRIPT_VERSION pin of this branch head. Supersedes #21 (same change; that PR could not be reopened after a force-push).