Repository navigation
prerender routes on prod mode - #5447
Merged
adhami3310 merged 1 commit intoJun 13, 2025
Merged
adhami3310 merged 1 commit into
adhami3310 merged 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
PR Summary
Major architectural migration from Next.js to React Router + Vite to fix 404 page handling and dynamic routing issues in production mode.
- Introduced React Router v7.6.2 with Vite for improved dynamic route handling and 404 page prerendering in
reflex/.templates/web/vite.config.js - Replaced Next.js Head/Document components with React Helmet v6.1.0 for better document head management in
reflex/components/core/helmet.py - Added new SitemapPlugin in
reflex/plugins/sitemap.pyfor automatic XML sitemap generation with dynamic route support - Upgraded minimum Node version to 20.0.0 and removed Next.js specific dependencies in
reflex/constants/installer.py - Consolidated routing configuration into new
reflex/.templates/web/app/routes.jsfor centralized route management
87 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
CodSpeed Performance ReportMerging #5447 will not alter performanceComparing Summary
|
masenf
approved these changes
Jun 13, 2025
adhami3310
deleted the
khaleel/eng-6296-pr-blocker-prod-mode-refresh-dynamic-route-404
branch
June 13, 2025 22:04
adhami3310
added a commit
that referenced
this pull request
Jun 13, 2025
* remix over next * make 404 page work * get layout working again * in theory, one can get rid of jsx, but that would be craaazy * Fix aria-* and other hiphenated props in `jsx` mode * compiler: preserve `app/routes.js` when purging this file only gets copied during `reflex init`, so don't blow it away * remove next/link stuff from `rx.link` * completely remove jsx files and replace them with js files * fix special props handling * fix empty name * fix reflex web syntax error * fix dynamic rendering * bring helmet to fix issues with head in component, bonus fix for next/script to make reflex web compile * got distracted * oh well * add helmet pyi * change vite config to fix builds * one should format their js files, prettier said * precommit * try to optimize jsx import * i don't know what i'm doing here * do this until we figure out how to fix that issue * ssr back to false * fix static directory name * merge changes * pyi * update versions * use unstable_optimizeDeps * reset testing py * remove helmet pyi and make the tests wait for token * please * add timeout and log * add logs for polling * add logs for starting backend * python buffered * require node 20 * add logs for line * repr the line * remove ansi * remove -s * brings back s for some time * maybe * no color * remove -s now? * fix redirects * maybe ? i'm not sure * move some of the config * make unit test cases pass * fix the checkpoints for react router * do some stuff with the url * fix client storage * yea that guy isn't happy * fix for react moment * fix three tests * try stuff with prerender * make it only on export * fix lazy components * prerender fix units * i couldn't get this guy to work but at least make some progress * fix tailwind test * fix test_event_actions * this shit is weird * simplify things further * precommit * remove / * fix datetime * make some progress on test dynamic route * remove work that wouldn't work * precommit * dynamic icon fix * merge * precommit * bring back some notion of link * remove weird component * fix dynamic route * app * update tailwind plugins * update pyi hashes * precommit * remove helmet * fix tests * fix config for esm * Revert "remove helmet" This reverts commit 2f300d1. * bring back helmet but only for scripts * upgrade react * fix cls * use rolldown * add sitemap * add deploy url handling * make native plugin only run on build * remove enableNativePlugin for now * remove setup frontend test * always have --bun ? * maybe * ok we can't get around that * we could do this though * fix pyi * Match static route before dynamic route for on_load * enable sitemap plugin * fix tailwind * also set inline colorScheme when the theme changes * upgrade RR * handle preset * removed unused ignore * fix build time and checkpoints * make frontend listening regex handle dev and prod * [ENG-6295] missing stylesheet issue (#5446) When the app specified custom `head_components`, the default meta was not being included. * add fix for strict mode being there all the time * prerender routes on prod mode (#5447) * [ENG-6294] fix test_event_actions for react-router When pushing an empty fragment onto react router, the page url does not actually change. * assert children * debounce input is default * grid into no ssr * pyi * [ENG-6292] add explicit on_mount StrictMode test cases * optimize REACT_ROUTER_LINK_PROPS check --------- Co-authored-by: Masen Furer <m_github@0x26.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this enables 404 page being prerendered and dynamic route to be fixed