Skip to content

chore: temporarily remove docker container credentials - #583

Merged
gabrielmfern merged 1 commit into
canaryfrom
chore/remove-container-credentials-for-now
Aug 21, 2025
Merged

gabrielmfern merged 1 commit into
canaryfrom
chore/remove-container-credentials-for-now

Conversation

@gabrielmfern

@gabrielmfern gabrielmfern commented Aug 21, 2025 •

Copy link
Copy Markdown
Member

This pull request removes the credentials field in all of our workflows. We
originally included this so that we could avoid getting rate limited by Docker
Hub's API, because they rate limit our anonymous requests.

But, it seems like the workflow files become invalid YML when running without
the secret and var for our Docker Hub, specifically on contributor forks. This
means that we basically aren't able to run our CI on pull requests from the
community.

I've tried to solve this by conditionally including the credentials, but the
syntax that GitHub provides us is simply not enough for this. The single thing
that works is having multiple workflows that check for having the secret and
var to run with/without the credentials, but that gets really messy really
fast.

So, after trying a myriad of solutions, it seemed simpler for me to just remove
these temporarily so that we can review things from the community while we
don't get this into a better shape.

Here's one pull request that we can't merge without bypassing the merging
rules, for example: #540


Summary by cubic

Temporarily removed container credentials from GitHub Actions workflows to restore CI on contributor forks where Docker Hub secrets aren’t available. This re-enables community PR checks and relies on anonymous Docker pulls.

  • Bug Fixes
    • Commented out credentials in lint, tests, PR title check, and pin-dependencies workflows.
    • Prevents invalid YAML and missing secret errors on forks.

@gabrielmfern gabrielmfern self-assigned this Aug 21, 2025
@gabrielmfern
gabrielmfern requested a review from a team as a code owner August 21, 2025 19:57
@gabrielmfern
gabrielmfern requested a review from cassiozen August 21, 2025 19:57

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@gabrielmfern
gabrielmfern merged commit 8867954 into canary Aug 21, 2025
@gabrielmfern
gabrielmfern deleted the chore/remove-container-credentials-for-now branch August 21, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants