Repository navigation
options constructor accepts a context object - #19
Merged
Merged
Conversation
Member
Author
|
BTW, the intent is to use this in conjunction with bunyan. Sometimes I want to propagate an error up two or three callbacks before logging it out - but I've lost the context by then. This allows me to keep that context tied with the error. The |
Contributor
|
Looks good to me, @DonutEspresso |
Member
Author
|
Looks like we're all on board - may have to come up with some custom serializers for bunyan to support dumping of context. |
DonutEspresso
added a commit
that referenced
this pull request
Feb 4, 2016
options constructor accepts a context object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm finding I frequently want to add contextual properties to an object I'm creating to store some context about what might have caused that error. i.e., if an http request failed, I might want to put the url on the error object.
Since we already have the options constructor, this seemed like a good place to put it. All arbitrary context properties are stored on the
contextproperty instead of directly on the error itself.Suggestions/feedback @yunong @micahr?