Skip to content

[Build] fail-on-missing contract not respected for NOT http AND webgui #23907

Open

Description

@guitargeek

If you want to build webgui=ON but have set http=OFF, the configuration step will disable webgui for you, even with fail-on-missing=ON. That's against the contract: features are not allowed to be silently disabled when requirement are missing, but the build should fail in that case. See SearchInsalledSoftware.cmake for how this is usually handled.

See https://github.com/root-project/root/blob/master/cmake/modules/RootBuildOptions.cmake#L368, the check introduced by 48ee1ed.

FYI @linev, @ferdymercury

Activity

  1. self-assigned this
    on Oct 30, 2026
  2. linev commented on Oct 30, 2026

    @linev
    Member

    It is relatively old code, now one can issue error instead disabling webgui option.

    There are other such places like

    if(unfold AND NOT xml)
      message(STATUS "Cannot enable unfold without enabling xml: unfold is disabled.")
      set(unfold OFF)
    endif()
    
  3. ferdymercury commented on Oct 30, 2026

    @ferdymercury
    Collaborator

    I already fixed all these snippets in #23092

  4. linev commented on Oct 30, 2026

    @linev
    Member

    I already fixed all these snippets in #23092

    Grate!
    I fear you will need to rebase it many times before we merge it.
    Please wait until many small fixes will be applied and probably backported to 6.42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions