Skip to content

Backport: Dynamic Path: ROOT_LIBRARY_PATH - #7794

Merged
pcanal merged 2 commits into
root-project:v6-24-00-patchesfrom
ChristianTackeGSI:pr/root_lib_env_624
Apr 7, 2021
Merged

Backport: Dynamic Path: ROOT_LIBRARY_PATH#7794
pcanal merged 2 commits into
root-project:v6-24-00-patchesfrom
ChristianTackeGSI:pr/root_lib_env_624

Conversation

@ChristianTackeGSI

@ChristianTackeGSI ChristianTackeGSI commented Apr 6, 2021

Copy link
Copy Markdown
Contributor

This is a backport of #7031 to the 6-24-00-patches branch.

I cherry-picked two of the three commits.
I left the test suite out, as it finally should go to roottest.git, as far as I understood it.

This is basically to get the thing started.

cc: @pcanal, @dennisklein

@ChristianTackeGSI
Use ROOT_LIBRARY_PATH in DynamicPath
c4d287d 
ROOT's "dynamic path" has some environment variables to
control it. Those environment variables have some issues:

* They are dependant on the OS (DYLD* on macOS,
  LD_LIBRARY_PATH on Linux, etc)
* LD_LIBRARY_PATH/etc modify the system's search path for
  dynamic libraries, which can result in all sorts of bad
  things.

We would like to have a dedicated environment variable,
that is
* OS independant.
* does only affect ROOT.

Let's name it ROOT_LIBRARY_PATH (suggestion on
mattermost.web.cern.ch).

It was suggested to put this into `system.rootrc` and/or
`.rootrc`.

This has some issues:

* `.rootrc` is good for a per user solution. We would like
  to have a package level solution.
* `system.rootrc` is usually a place for the local sysadmin
  to modify. It could be used by a distribution package to
  put "defaults". But that's not really nice.
* Finally, `.rootrc` entries replace `system.rootrc`
  entries. So any package level configuration would be gone
  the moment, that the user sets `Unix.*.Root.DynamicPath`.

So getting the above mentioned environment variable to work
at a package level, means to put it into TUnixSystem.cpp /
TWinNTSystem.cxx.

Co-Authored-By: Bertrand Bellenot @bellenot
@ChristianTackeGSI
Release Notes for ROOT_LIBRARY_PATH
c6f9ffd 
Add a short description of the new feature to the 6.24
releases notes.
@phsft-bot

phsft-bot commented Apr 6, 2021

Copy link
Copy Markdown

Can one of the admins verify this patch?

@pcanal

pcanal commented Apr 6, 2021

Copy link
Copy Markdown
Member

@phsft-bot build

@phsft-bot

phsft-bot commented Apr 6, 2021

Copy link
Copy Markdown

Starting build on ROOT-debian10-i386/cxx14, ROOT-performance-centos8-multicore/default, ROOT-fedora30/cxx14, ROOT-fedora31/noimt, ROOT-ubuntu16/nortcxxmod, mac1014/python3, mac11.0/cxx17, windows10/cxx14
How to customize builds

@phsft-bot

phsft-bot commented Apr 6, 2021

Copy link
Copy Markdown

Build failed on windows10/cxx14.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Errors:

  • [2021-04-06T18:08:45.651Z] CMake Error at interpreter/llvm/src/cmake/modules/AddLLVM.cmake:432 (add_library):
  • [2021-04-06T18:08:45.651Z] CMake Error at interpreter/llvm/src/cmake/modules/AddLLVM.cmake:472 (add_library):
  • [2021-04-06T18:08:45.654Z] CMake Error at interpreter/llvm/src/cmake/modules/AddLLVM.cmake:432 (add_library):
  • [2021-04-06T18:08:45.654Z] CMake Error at interpreter/llvm/src/cmake/modules/AddLLVM.cmake:472 (add_library):
  • [2021-04-06T18:08:45.655Z] CMake Error at interpreter/llvm/src/cmake/modules/AddLLVM.cmake:432 (add_library):
  • [2021-04-06T18:08:45.655Z] CMake Error at interpreter/llvm/src/cmake/modules/AddLLVM.cmake:472 (add_library):
  • [2021-04-06T18:08:45.937Z] CMake Error at C:/Program Files/CMake/share/cmake-3.18/Modules/ExternalProject.cmake:3152 (add_custom_target):
  • [2021-04-06T18:08:45.937Z] CMake Error at interpreter/cling/tools/plugins/clad/CMakeLists.txt:83 (add_library):
  • [2021-04-06T18:08:45.937Z] CMake Error at interpreter/cling/tools/plugins/clad/CMakeLists.txt:83 (add_library):
  • [2021-04-06T18:09:13.033Z] CMake Error at C:/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1093 (message):

@ChristianTackeGSI

ChristianTackeGSI commented Apr 6, 2021

Copy link
Copy Markdown
Contributor Author

@bellenot can you help with the windows build error?

@pcanal

pcanal commented Apr 6, 2021

Copy link
Copy Markdown
Member

The windows error is unrelated. It seems that a build area used for the older Cling version (using llvm v5) is being reused.

@phsft-bot

phsft-bot commented Apr 6, 2021

Copy link
Copy Markdown

Build failed on mac1014/python3.
Running on macphsft17.dyndns.cern.ch:/build/jenkins/workspace/root-pullrequests-build
See console output.

Failing tests:

@pcanal

pcanal commented Apr 6, 2021

Copy link
Copy Markdown
Member

The macos failure is an infrasture issue:

Plugin dlopen(libXrdSecgsi-4.so, 256): image not found sec.protocol libXrdSecgsi-4.so

@pcanal
pcanal merged commit 006a7ca into root-project:v6-24-00-patches Apr 7, 2021
@ChristianTackeGSI
ChristianTackeGSI deleted the pr/root_lib_env_624 branch April 7, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Axel-Naumann Axel-Naumann Awaiting requested review from Axel-Naumann Axel-Naumann is a code owner
@pcanal pcanal Awaiting requested review from pcanal pcanal is a code owner

Assignees

@pcanal pcanal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristianTackeGSI @phsft-bot @pcanal