[sferik]

This gets line, branch and method coverage to 100% and turns on kettle-soup-cover's new strict mode to keep it there. A run below 100% on any of the three fails, locally and in the coverage workflow.

Coverage was already close. Line coverage went from 98.48% to 100%, branch from 93.53% to 100%, and method from 98.99% to 100%. Most of the gap was SanitizedLogFormatter, so most of the 13 new specs log real requests and responses through it: redacting code= in a logged URL without touching the actual request, string bodies shaped like Hash#inspect, non-string bodies, nil values, cyclic arrays, and envs without a URL or body. The rest cover Response#parser memoization and protocol-relative redirects for a location without query= or fragment=. Three branches can't be reached in any single run, so they're excluded with inline simplecov:disable branch comments saying why. Two only take their else arm on Faraday 0.x, and the MultiXML/MultiXml choice depends on which multi_xml release is installed. Nothing else in lib/ changed.

The config is now just K_SOUP_COV_MIN_STRICT=true in mise.toml, .envrc and coverage.yml, from kettle-dev/kettle-soup-cover#33, with K_SOUP_COV_MIN_LINE and K_SOUP_COV_MIN_BRANCH at 100 everywhere, so nothing says 76/92 or 78/97 anymore. An earlier version of this PR loaded SimpleCov's strict profile itself and needed a couple of workarounds to stop kettle-soup-cover from overwriting it. Those are all gone. Strict mode, and the fix that keeps method coverage on in turbo_tests2 workers, shipped in kettle-soup-cover 3.0.15, so coverage.gemfile now requires it. With it, plain RSpec and turbo_tests2 both pass the full suite at 100% line, branch and method coverage, and both fail on a single uncovered method.

[Copilot]

🟡 Changes recommended

Preserve the local and CI coverage settings through the repository’s templating workflow.

1 open issue

• Preserve strict runner setting in the generated coverage workflow · New

What changed in this PR

This pull request raises line, branch, and method coverage enforcement to 100% using SimpleCov’s strict profile, adds targeted coverage tests, and aligns local and CI test settings.

Changes:

• Adds coverage specs for sanitized logging, parser memoization, and protocol-relative redirects.
• Loads SimpleCov’s strict profile and synchronizes coverage thresholds.
• Switches coverage runs to plain RSpec and documents unreachable compatibility branches.
• Updates the gradual RuboCop lock.

File	Description
spec/​spec_helper.rb	Restores strict SimpleCov thresholds after kettle-soup-cover configuration.
spec/​oauth2/​sanitized_log_formatter_spec.rb	Adds formatter edge-case and request/response logging coverage.
spec/​oauth2/​response_spec.rb	Tests response parser memoization.
spec/​oauth2/​client_spec.rb	Covers redirects without query and fragment writers.
mise.toml	Sets local coverage thresholds and the RSpec runner.
lib/​oauth2/​sanitized_log_formatter.rb	Excludes the Faraday 0.x compatibility branch.
lib/​oauth2/​response.rb	Excludes the version-dependent XML parser branch.
lib/​oauth2/​client.rb	Excludes the Faraday 0.x formatter branch.
.simplecov	Loads the strict coverage profile when hard enforcement is enabled.
.rubocop_gradual.lock	Updates recorded lint locations after spec additions.
.github/​workflows/​coverage.yml	Sets CI coverage thresholds and the RSpec runner.
.envrc	Aligns environment coverage thresholds and runner settings.

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

Protect the template-managed coverage settings in .envrc and mise.toml from being overwritten by future template updates.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Protect local coverage settings from template overwrites

.envrc:32

These new local coverage settings are outside a kettle-jem:freeze block, but .structuredmerge/kettle-jem.lock identifies .envrc as a generated template file and the default merge preference is template (.structuredmerge/kettle-jem.yml:583-587). A future template pass can therefore replace these values—including KETTLE_TEST_RUNNER=rspec—with the template defaults, so local runs silently return to turbo_tests2 and no longer enforce method coverage. Wrap this block in freeze markers or add an explicit destination-preferred merge rule for .envrc.

1 resolved since last review

• Preserve strict runner setting in the generated coverage workflow

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

Protect the .envrc coverage settings from kettle-jem template regeneration.

No open issues 🎉

_{Review effort: Lite}

[Copilot]

🟡 Changes recommended

Unresolved critical configuration errors can prevent coverage and spec runs from starting, and local enforcement can be bypassed.

3 open issues

• Reference nested Constants for hard coverage setting · New
• Use nested Constants for hard coverage spec setting · New
• Set KETTLE_TEST_RUNNER in .envrc · New

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

Update the template sources or destination-preferred configuration so .envrc and coverage.yml retain the coverage settings after regeneration.

3 open issues

• Use nested Constants for hard coverage spec setting
• Reference nested Constants for hard coverage setting
• Set KETTLE_TEST_RUNNER in .envrc

_{Review effort: Lite}

[Copilot]

🔵 Needs a closer look

Two moderate findings remain regarding inconsistent GitLab method-coverage enforcement and the generated workflow source.

2 open issues

• Use nested Constants for hard coverage spec setting
• Reference nested Constants for hard coverage setting

1 resolved since last review

• Set KETTLE_TEST_RUNNER in .envrc

_{Review effort: Lite}