Skip to content

Move rubygems to core from stdlib - #1107

Merged
pocke merged 4 commits into
ruby:masterfrom
pocke:Move_rubygems_to_core_from_stdlib
Oct 1, 2022
Merged

pocke merged 4 commits into
ruby:masterfrom
pocke:Move_rubygems_to_core_from_stdlib

Conversation

@pocke

@pocke pocke commented Sep 10, 2022 •

Copy link
Copy Markdown
Member

Fix #872

This PR moves rubygems to core from stdlib.

This change keeps compatibility. By this change, library 'rubygems' in Stepfile become to load nothing but it just displays a warning message.

In the future (maybe RBS v3.0?), we should remove the warning and make library 'rubygems' failure.

Comment thread Steepfile
signature "stdlib/rdoc/0/"

# Please remove the following line after releasing #1107
signature "core/rubygems/"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steep uses released RBS, so we need to specify the core/rubygems directory until this PR is released to RubyGems.

@pocke
pocke marked this pull request as ready for review September 11, 2022 07:02

@soutaro soutaro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 💎

@pocke
pocke merged commit 6c847d1 into ruby:master Oct 1, 2022
@pocke
pocke deleted the Move_rubygems_to_core_from_stdlib branch October 1, 2022 05:21
@pocke pocke mentioned this pull request Feb 24, 2023
2 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move stdlib/rubygems/ to core/rubygems/

2 participants