Repository navigation
Add method to_d (convert into BigDecimal) to some classes - #936
Merged
Merged
Conversation
Integer, Float, String, BigDecimal, Rational, Complex and NilClass
ksss
reviewed
Mar 24, 2022
ksss
left a comment
Collaborator
There was a problem hiding this comment.
One way to do it is to create bigdecimal-util like bigdecimal-math, but RBS seems to be a tool that takes convenience over correctness, so this seems to be the way to go.
|
|
||
| # call-seq: | ||
| # a.to_d -> bigdecimal | ||
| # |
Collaborator
There was a problem hiding this comment.
Maybe call-seq is not necessary.
I think you should use the rbs annotate tool.
soutaro
previously approved these changes
Mar 28, 2022
soutaro
left a comment
Member
There was a problem hiding this comment.
Could you try copying RDoc using rbs annotate?
soutaro
requested changes
Mar 28, 2022
soutaro
left a comment
Member
There was a problem hiding this comment.
Could you try copying RDoc using rbs annotate?
soutaro
approved these changes
Mar 31, 2022
soutaro
left a comment
Member
There was a problem hiding this comment.
Merging this PR. Will update the docs myself.
Merged
ksss
added a commit
to ksss/gem_rbs_collection
that referenced
this pull request
Feb 2, 2025
See also: - ruby/rbs#2258 - ruby/rbs#817 - ruby/rbs#936 - ruby/rbs#1053 Thank you: - @ybiquitous - @takahashim - @piotaixr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target classes: Integer, Float, String, BigDecimal, Rational, Complex and NilClass