Simplecov failing with new Rexml 3.4.2

[jmthomas]

I'm not sure if this is you or them but running simplecov against the new rexml throws the following:

/.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:524:in 'REXML::Parsers::BaseParser#pull_event': #<NoMethodError: undefined method 'eof?' for nil> (REXML::ParseException)
.gems/gems/rexml-3.4.2/lib/rexml/source.rb:275:in 'REXML::IOSource#read_until'
/.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:731:in 'REXML::Parsers::BaseParser#process_comment'
/.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:457:in 'REXML::Parsers::BaseParser#pull_event'
/.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:249:in 'REXML::Parsers::BaseParser#pull'
/.gems/gems/rexml-3.4.2/lib/rexml/parsers/treeparser.rb:21:in 'REXML::Parsers::TreeParser#parse'
/.gems/gems/rexml-3.4.2/lib/rexml/document.rb:466:in 'REXML::Document#build'
/.gems/gems/rexml-3.4.2/lib/rexml/document.rb:103:in 'REXML::Document#initialize'
/.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:37:in 'Class#new'
/.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:37:in 'SimpleCov::Formatter::CoberturaFormatter#result_to_xml'
/.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:20:in 'SimpleCov::Formatter::CoberturaFormatter#format'
.gems/gems/simplecov-0.22.0/lib/simplecov/result.rb:51:in 'SimpleCov::Result#format!'
/.gems/gems/simplecov-0.22.0/lib/simplecov/configuration.rb:197:in 'block in SimpleCov::Configuration#at_exit'
/.gems/gems/simplecov-0.22.0/lib/simplecov.rb:189:in 'SimpleCov.run_exit_tasks!'
/.gems/gems/simplecov-0.22.0/lib/simplecov.rb:179:in 'SimpleCov.at_exit_behavior'
/.gems/gems/simplecov-0.22.0/lib/simplecov/defaults.rb:30:in 'block in <top (required)>'
...
Exception parsing
Line: 3
Position: 214
Last 80 unconsumed characters:

	from /.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:249:in 'REXML::Parsers::BaseParser#pull'
	from /.gems/gems/rexml-3.4.2/lib/rexml/parsers/treeparser.rb:21:in 'REXML::Parsers::TreeParser#parse'
	from /.gems/gems/rexml-3.4.2/lib/rexml/document.rb:466:in 'REXML::Document#build'
	from /.gems/gems/rexml-3.4.2/lib/rexml/document.rb:103:in 'REXML::Document#initialize'
	from /.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:37:in 'Class#new'
	from /.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:37:in 'SimpleCov::Formatter::CoberturaFormatter#result_to_xml'
	from /.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:20:in 'SimpleCov::Formatter::CoberturaFormatter#format'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov/result.rb:51:in 'SimpleCov::Result#format!'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov/configuration.rb:197:in 'block in SimpleCov::Configuration#at_exit'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov.rb:189:in 'SimpleCov.run_exit_tasks!'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov.rb:179:in 'SimpleCov.at_exit_behavior'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov/defaults.rb:30:in 'block in <top (required)>'
/.gems/gems/rexml-3.4.2/lib/rexml/source.rb:275:in 'REXML::IOSource#read_until': undefined method 'eof?' for nil (NoMethodError)

        read if @scanner.eos? and !@source.eof?
                                          ^^^^^
	from /.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:731:in 'REXML::Parsers::BaseParser#process_comment'
	from /.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:457:in 'REXML::Parsers::BaseParser#pull_event'
	from /.gems/gems/rexml-3.4.2/lib/rexml/parsers/baseparser.rb:249:in 'REXML::Parsers::BaseParser#pull'
	from /.gems/gems/rexml-3.4.2/lib/rexml/parsers/treeparser.rb:21:in 'REXML::Parsers::TreeParser#parse'
	from /.gems/gems/rexml-3.4.2/lib/rexml/document.rb:466:in 'REXML::Document#build'
	from /.gems/gems/rexml-3.4.2/lib/rexml/document.rb:103:in 'REXML::Document#initialize'
	from /.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:37:in 'Class#new'
	from /.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:37:in 'SimpleCov::Formatter::CoberturaFormatter#result_to_xml'
	from /.gems/gems/simplecov-cobertura-2.1.0/lib/simplecov-cobertura.rb:20:in 'SimpleCov::Formatter::CoberturaFormatter#format'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov/result.rb:51:in 'SimpleCov::Result#format!'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov/configuration.rb:197:in 'block in SimpleCov::Configuration#at_exit'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov.rb:189:in 'SimpleCov.run_exit_tasks!'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov.rb:179:in 'SimpleCov.at_exit_behavior'
	from /.gems/gems/simplecov-0.22.0/lib/simplecov/defaults.rb:30:in 'block in <top (required)>'

See simplecov-ruby/simplecov#1138

[kou]

Could you share how to reproduce this?
(Should we discuss this in simplecov-ruby/simplecov#1138 ?)

[kou]

gem install simplecov-cobertura
ruby -r simplecov -r simplecov-cobertura -e 'SimpleCov.formatter = SimpleCov::Formatter::CoberturaFormatter; SimpleCov.start'

[kou]

jessebs/simplecov-cobertura#44 fixed this but REXML::Document.new should not report this error for this invalid XML. We should improve the error handling for this case.