Repository navigation
ZJIT: Remove GuardShape from known-frozen object with same shape - #15863
Merged
Merged
Conversation
tekknolagi
approved these changes
Jan 13, 2026
tekknolagi
left a comment
Contributor
There was a problem hiding this comment.
looks great --thank you!
tekknolagi
reviewed
Jan 13, 2026
❌ 1/67284 Tests Failedtest/-ext-/iseq_load/test_iseq_load.rb#test_stressful_roundtrip |
k0kubun
approved these changes
Jan 13, 2026
Contributor
|
Thanks! |
tekknolagi
pushed a commit
that referenced
this pull request
Jan 14, 2026
Resolves TODO added in #15863 (See #15863 (comment)) Adds a method `Type::has_value` for comparing value specialized types with a `Const`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Shopify#915
When we have
LoadFieldwith aShapereturn type, we can fold it similar to the object case.GuardBitEqualscan be removed when the argument isConstand the values are equal.The behaviors for loading instances variables from frozen/dynamic objects are already covered in existing tests so no new tests were added.