Conversation
maebeale
force-pushed
the
maebeale/multiselect-people-filters
branch
from
September 25, 2026 20:49
eec0f34 to
edea751
Compare
Admins routinely want everyone across several tags or topics, not one at a time. Convert both single-select filters to searchable TomSelect multiselects everywhere they appear — People directory, Subscriptions list, attendees index, and the bulk email recipient picker — via a shared events/_filter_multiselect partial. Server scopes and the in-memory reminder filter now accept arrays; a new hidden_filter_fields helper keeps array filters intact through GET round-trips. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The default TomSelect control renders a solid white box that clashes with the tinted filter panels it sits on. Switch it to the existing `ts-flat` variant (CSS already written for the searchable-checkbox multiselect), so the inner control is transparent and the field reads like its native-select neighbors. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/multiselect-people-filters
branch
from
September 30, 2026 18:36
e198a67 to
344299d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 contained filter-param change (scalar→array) across 4 filter locations, covered by request/service specs
Staff tag and topic subscription filters now let admins pick several values at once instead of one — pull everyone across any of the chosen tags/topics in a single search.
Where
/people) — staff tag and topic subscription/topic_subscriptions) — topicHow
events/_filter_multiselectpartial: a searchable TomSelect (the existingsearchable-checkboxcontroller) multi-select, the counterpart ofevents/_filter_select.param[]); every consuming scope (Person.subscribed_to_topic,EventRegistration.registrant_topic_subscription,ReminderRecipientFilter) accepts one or many, so old single-value links still work.hidden_filter_fieldshelper re-emits array filters askey[]so they survive GET round-trips (subscription form return params, email-addresses page).data-placeholder.Notes