Conversation
bsbonus
commented
May 22, 2025
bsbonus
commented
May 22, 2025
2 tasks
Collaborator
|
LGTM functionally. Over to @dorner for technical review. |
dorner
requested changes
May 23, 2025
dorner
previously requested changes
May 30, 2025
|
|
||
| # Check that the remaining columns match our expected case-insensitive sort | ||
| expect(item_columns).to eq(expected_order) | ||
| end |
Collaborator
There was a problem hiding this comment.
See previous comments re hardcoded CSVs.
Collaborator
|
For this, it looks like we should switch to a CSV fixture based spec, and then it should be ready to merge. |
Collaborator
|
@bsbonus Please take a look at this comment: #5200 (comment). Are you available to finish this PR? Thanks! |
Per review: compare the full generated CSV against fixture files in spec/fixtures/files/ instead of order-independent header/index lookups, so any change to column order or content fails loudly (a CSV header reorder is a breaking change for consumers). - Pin the product drive / manufacturer / donation site names in the factories so the fixtures can be fully static, replacing the source_name interpolation helper - Rewrite the new inactive-item and unused-item tests (bug rubyforgood#5152 coverage) as full-CSV fixture comparisons - Fold the #generate_csv_data describe block's unique coverage (case-insensitive column sort) into a hardcoded fixture test and drop the rest, which duplicated the fixture assertions in loose form Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BNy2e1J81K8xbvXraCeN8e
awwaiid
approved these changes
Jul 19, 2026
Contributor
|
@bsbonus: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
X I have performed a self-review of my own code,
X I have commented my code, particularly in hard-to-understand areas,
X I have made corresponding changes to the documentation,
X I have added tests that prove my fix is effective or that my feature works,
X New and existing unit tests pass locally with my changes ("bundle exec rake"),
X Title include "WIP" if work is in progress.
X I acknowledge that I will not force push my branch once reviews have started.
Parital #5152 - partially, will be broken up into multiple PRs
Description
This modifies the query used by the Donations export to also include inactive items and items that were not donated, so that the headers are consistent with the "Distributions" export logic.
Type of change
How Has This Been Tested?
PLease see attached XLXS files to help make sense of this.
This CSV will serve as a reference point for Donations for the item columns, at least.
Distributions_as_reference.csv
This is an example of the data BEFORE the fix -- note how many fewer item columns are in the export
donations_before.csv
This is the fixed version. Note that the total number of item columns matches the Distribution export
donations_after_fix.csv