Conversation
dorner
approved these changes
Jul 10, 2026
dorner
left a comment
Collaborator
There was a problem hiding this comment.
Better than waiting for mine to be merged! 😁
Closed
Contributor
|
@rodrigovirgilio: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5615
Description
The "detects duplicate items" system test used the "item_..." field prefix, but the kit form builds nested fields via
fields_for @kit.kit_item, where kit_item is a KitItem (STI of Item), so Rails generates ids prefixed "kit_item_...". This mismatch made Capybara unable to find the select/input, failing CI.Type of change
How Has This Been Tested?
Screenshots