This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Migrate tree-sitter and tree-sitter-ruby to WASM distribution #506
Description
Move tree-sitter and tree-sitter-ruby to use a WASM build instead of prebuilt binaries. This should yield a better user experience + allow us to drop prebuild.
More info here
Activity
wingrunr21 commentedon Jul 15, 2019
WASM support was started over the weekend. Just need to test a few things out and verify the solution works cross-platform. VSCode does not officially support WASM in extensions so want to make sure this is functioning as expected.
razzeee commentedon Jul 18, 2019
Btw just FYI, here's another VSCode addon that has been shipping wasm tree sitter files for some time now https://github.com/georgewfraser/vscode-tree-sitter/tree/master/parsers
wingrunr21 commentedon Jul 18, 2019
https://github.com/rubyide/vscode-ruby/tree/tree_sitter_wasm 😉
The issue wasn't how to ship. The issue was support. I use the cursor to traverse the tree and a few features in that just landed yesterday.
razzeee commentedon Jul 18, 2019
minkir014 commentedon Jul 18, 2019
When do you intend to fully convert prepuilt binaries to WASM to solve problems of prebuilt binaries instead of fixing node-tree-sitter problems since the PR against node-tree-sitter has some problems.
wingrunr21 commentedon Jul 18, 2019
@razzeee Ya, I think support works in practice but microsoft/vscode#65559. Luckily, the way
tree-sitteris built the appropriate member functions for memory management can be defined in the types it ships vs those from the WASM spec or emscripten@minkir014 ASAP
minkir014 commentedon Jul 18, 2019
Have you encountered any problems with WASM or it's working properly??
wingrunr21 commentedon Aug 13, 2019
This change is in
master. It will go out with the next release.minkir014 commentedon Aug 27, 2019
When will WASM version of the extension go out??
Maybe, this will help to fix all issues.
wingrunr21 commentedon Aug 27, 2019
I doubt it's going to fix all issues but I'm packaging a ton of bug fixes into the next release.
I have one final issue to resolve and I will be doing the release. Fix is written just need to test an edge case I thought of today.
wingrunr21 commentedon Sep 2, 2019
This was shipped in v0.25.0. There was an issue with publishing that version to the Marketplace so v0.25.1 is the first version with the WASM switch.