Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Call the async-callback to clear parseQueue of items - #399

Merged
wingrunr21 merged 1 commit into
rubyide:masterfrom
peret:fix-saturated-locate-queue
Oct 29, 2018
Merged

wingrunr21 merged 1 commit into
rubyide:masterfrom
peret:fix-saturated-locate-queue

Conversation

@peret

@peret peret commented Oct 23, 2018 •

Copy link
Copy Markdown
Contributor

Fixes #398

Not calling the callback caused a bug that meant that after a few tasks
were enqueued on the parseQueue (i.e. a few change-/create-events), all
incoming tasks were queued and never executed. That lead to newly added
symbols not being added to the symbols list and the locations of all
symbols after that being off.

  • The build passes
  • TSLint is mostly happy
  • Prettier has been run

Not calling the callback caused a bug that meant that after a few tasks
were enqueued on the parseQueue (i.e. a few change-/create-events), all
incoming tasks were queued and never executed. That lead to newly added
symbols not being added to the symbols list and the locations of all
symbols after that being off.
@wingrunr21

Copy link
Copy Markdown
Collaborator

Thanks!

@wingrunr21
wingrunr21 merged commit 251f666 into rubyide:master Oct 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants