Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Add Unix domain socket support to the debugger. - #586

Merged
wingrunr21 merged 1 commit into
rubyide:masterfrom
jvilk-stripe:jvilk/add-unix-domain-socket-support
Feb 23, 2020
Merged

wingrunr21 merged 1 commit into
rubyide:masterfrom
jvilk-stripe:jvilk/add-unix-domain-socket-support

Conversation

@jvilk-stripe

@jvilk-stripe jvilk-stripe commented Feb 7, 2020 •

Copy link
Copy Markdown
Contributor

Add Unix domain socket support to the debugger.

Makes it possible to attach to running Ruby processes via a Unix domain socket.

At Stripe, we're using a forked version of this extension in order to securely attach to Ruby services running on development boxes via Unix domain sockets. We'd like to upstream the change. :)

Let me know if you need any more information or if this PR needs any additional changes.

  • The build passes - The debugger tests fail locally for me with or without the change.
  • TSLint is mostly happy - 🤷‍♂
  • Prettier has been run - No, because this package seems to have never been prettiered and I didn't want to dirty the diff. The existing changes are from VS Code's built-in formatter, which seems to have fixed some whitespace issues without radically transforming the code. If this is distracting, I can golf down the diff. :)

Makes it possible to attach to running Ruby processes via a Unix domain socket.
@jvilk-stripe

Copy link
Copy Markdown
Contributor Author

@wingrunr21 Do you have any concerns about this PR? It would be super great if Stripe could get back on the public version of the extension.

@wingrunr21

Copy link
Copy Markdown
Collaborator

I will take a look at this this week. Apologies, I haven't had time to work on this extension much in the past few months. There are a few issues and PRs waiting for review

@wingrunr21
wingrunr21 merged commit fdc33a3 into rubyide:master Feb 23, 2020
@jvilk-stripe
jvilk-stripe deleted the jvilk/add-unix-domain-socket-support branch February 24, 2020 16:33
@jvilk-stripe

Copy link
Copy Markdown
Contributor Author

Thank you!!

@wingrunr21

Copy link
Copy Markdown
Collaborator

Yep, release isn't published yet as I think I may have found a minor issue with a PR. I'm going to look at that tonight though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants