Skip to content

Support for new architecture #243

Open

Description

@tarkcelk

Describe the bug
Pdf package doesn't work when build a project with new architecture enabled, need to update the package to be compatible.

To Reproduce

  • Create a react native project with latest version (My case was 0.71.4)
  • Enable the new architecture.
  • Install this package and build the project.
  • Render a pdf and see the fabric incompatibility warning.

Steps to reproduce the behavior:

  1. Render PDF with any kind of resource.
  2. See the fabric incompatibility warning

Expected behavior
Proper rendering when new architecture is enabled.

Screenshots
Screenshot_1679408336

Smartphone (please complete the following information):

  • Device: Pixel 2 , iPhone 13
  • OS: Android, iOS
  • Version API 29, iOS 16.0

Activity

  1. rumax commented on Mar 27, 2023

    @rumax
    Owner

    Hi @tarkcelk, new new architecture is still experimental, right?

    This documentation is still experimental and details are subject to changes as we iterate.

  2. stale commented on May 15, 2023

    @stale

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

  3. mrshahzeb7 commented on Oct 2, 2023

    @mrshahzeb7

    Now you can use the "New Renderer Interop Layer"
    The interop layer is shipped with React Native 0.72

    Just add a component name like this in react-native.config.js

    module.exports = {
    project:{
    android: {
    unstable_reactLegacyComponentNames: [ "PDFView" ]
    },
    ios: {
    unstable_reactLegacyComponentNames: [ "PDFView" ]
    }
    },
    };

    "The interop layer is a feature that lets you reuse legacy Native Components in New Architecture apps"

    Read More
    https://github.com/reactwg/react-native-new-architecture/discussions/135

  4. removed
    wontfixThis will not be worked on
    on Oct 2, 2023
  5. tarkcelk commented on Nov 24, 2023

    @tarkcelk
    Author

    @mrshahzeb7 thanks, i will be looking to that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions