Name explicit registers in conflict register errors for inline assembly by GeorgeWort · Pull Request #117912 · rust-lang/rust

GeorgeWort · 2023-11-14T15:46:04Z

No description provided.

rustbot · 2023-11-14T15:46:13Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

petrochenkov · 2023-11-17T20:52:26Z

Some more tests in tests/ui/asm also need an update.
@rustbot author

petrochenkov · 2023-11-28T12:36:19Z

r=me with the style nit addressed #117912 (comment)

petrochenkov · 2023-11-28T18:55:44Z

@bors r+

bors · 2023-11-28T18:55:46Z

📌 Commit e0bfb61 has been approved by petrochenkov

It is now in the queue for this repository.

Name explicit registers in conflict register errors for inline assembly

bors · 2023-11-29T16:03:05Z

⌛ Testing commit e0bfb61 with merge 5f0ff7c...

Name explicit registers in conflict register errors for inline assembly

bors · 2023-11-29T16:06:03Z

💔 Test failed - checks-actions

petrochenkov · 2023-11-29T16:15:50Z

@bors retry

petrochenkov · 2023-11-29T19:00:10Z

@bors retry

bors · 2023-11-29T20:06:13Z

⌛ Testing commit e0bfb61 with merge fce2c02...

Name explicit registers in conflict register errors for inline assembly

bors · 2023-11-29T20:08:12Z

💔 Test failed - checks-actions

rust-log-analyzer · 2023-11-29T20:13:37Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

compiler-errors · 2023-11-29T20:25:25Z

@bors retry

bors · 2023-11-30T05:16:49Z

⌛ Testing commit e0bfb61 with merge 3a19e68...

Name explicit registers in conflict register errors for inline assembly

rust-log-analyzer · 2023-11-30T05:19:04Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2023-11-30T05:20:34Z

💔 Test failed - checks-actions

petrochenkov · 2023-12-02T11:30:05Z

@bors retry

bors · 2023-12-02T13:38:51Z

⌛ Testing commit e0bfb61 with merge 4e3dc97...

bors · 2023-12-02T15:35:47Z

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 4e3dc97 to master...

rust-timer · 2023-12-02T16:58:14Z

Finished benchmarking commit (4e3dc97): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.5%, 2.6%]	2
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	2.6%	[2.5%, 2.6%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.874s -> 673.421s (0.23%)
Artifact size: 313.92 MiB -> 313.90 MiB (-0.01%)

…agnostic, r=Amanieu Preserve explicit register names in inline asm diagnostics This PR adds diagnostic-only metadata directly to each register-bearing HIR operand, and replaces rust-lang#117912 AST lookup with the new HIR metadata. Fixes rust-lang#159409

Rollup merge of #160068 - qaijuang:fix-asm-register-alias-diagnostic, r=Amanieu Preserve explicit register names in inline asm diagnostics This PR adds diagnostic-only metadata directly to each register-bearing HIR operand, and replaces #117912 AST lookup with the new HIR metadata. Fixes #159409

rustbot assigned petrochenkov Nov 14, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 14, 2023

This comment has been minimized.

Sign in to view

petrochenkov reviewed Nov 17, 2023

View reviewed changes

Comment thread compiler/rustc_ast_lowering/src/asm.rs Outdated

Comment thread compiler/rustc_ast_lowering/src/asm.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2023

GeorgeWort force-pushed the master branch from 2c87843 to a907b80 Compare November 28, 2023 10:30

This comment has been minimized.

Sign in to view

Name explicit registers in conflict register errors for inline assembly

e0bfb61

GeorgeWort force-pushed the master branch from a907b80 to e0bfb61 Compare November 28, 2023 10:40

petrochenkov reviewed Nov 28, 2023

View reviewed changes

Comment thread compiler/rustc_ast_lowering/src/asm.rs

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2023

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2023

Rollup merge of rust-lang#117912 - GeorgeWort:master, r=petrochenkov

97dfcc6

Name explicit registers in conflict register errors for inline assembly

matthiaskrgr mentioned this pull request Nov 29, 2023

Rollup of 6 pull requests #118432

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2023

Rollup merge of rust-lang#117912 - GeorgeWort:master, r=petrochenkov

ed70120

Name explicit registers in conflict register errors for inline assembly

matthiaskrgr mentioned this pull request Nov 29, 2023

Rollup of 6 pull requests #118435

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023

Auto merge of rust-lang#117912 - GeorgeWort:master, r=petrochenkov

5f0ff7c

Name explicit registers in conflict register errors for inline assembly

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2023

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023

Auto merge of rust-lang#117912 - GeorgeWort:master, r=petrochenkov

fce2c02

Name explicit registers in conflict register errors for inline assembly

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2023

Auto merge of rust-lang#117912 - GeorgeWort:master, r=petrochenkov

3a19e68

Name explicit registers in conflict register errors for inline assembly

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2023

bors merged commit 4e3dc97 into rust-lang:master Dec 2, 2023

rustbot added this to the 1.76.0 milestone Dec 2, 2023

qaijuang mentioned this pull request Jul 28, 2026

Preserve explicit register names in inline asm diagnostics #160068

Merged

Uh oh!

Conversation

GeorgeWort commented Nov 14, 2023

Uh oh!

rustbot commented Nov 14, 2023

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

petrochenkov commented Nov 17, 2023

Uh oh!

This comment has been minimized.

Uh oh!

petrochenkov commented Nov 28, 2023

Uh oh!

petrochenkov commented Nov 28, 2023

Uh oh!

bors commented Nov 28, 2023

Uh oh!

bors commented Nov 29, 2023

Uh oh!

bors commented Nov 29, 2023

Uh oh!

petrochenkov commented Nov 29, 2023

Uh oh!

petrochenkov commented Nov 29, 2023

Uh oh!

bors commented Nov 29, 2023

Uh oh!

bors commented Nov 29, 2023

Uh oh!

rust-log-analyzer commented Nov 29, 2023

Uh oh!

compiler-errors commented Nov 29, 2023

Uh oh!

bors commented Nov 30, 2023

Uh oh!

rust-log-analyzer commented Nov 30, 2023

Uh oh!

bors commented Nov 30, 2023

Uh oh!

petrochenkov commented Dec 2, 2023

Uh oh!

bors commented Dec 2, 2023

Uh oh!

bors commented Dec 2, 2023

Uh oh!

rust-timer commented Dec 2, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants