Submodule update of rustc-perf by JonathanBrouwer · Pull Request #165072 · rust-lang/rust

JonathanBrouwer · 2026-10-28T10:48:47Z

View all comments

So we can play with rust-lang/rustc-perf#2624

r? @Kobzol

rustbot · 2026-10-28T10:48:54Z

kobzol is not on the review rotation at the moment.
They may take a while to respond.

Kobzol · 2026-10-28T10:49:47Z

@bors try

Submodule update of rustc-perf

rust-bors · 2026-10-28T11:47:20Z

☀️ Try build successful (CI)
Build commit: 2b144d8 (2b144d8c702e00e87c36cc33139f1deec2cd9755)
Base parent: 41089d0 (41089d07a0a2afc16adfe28a760d94d73d7298a4)

Kobzol · 2026-10-28T11:55:12Z

Thanks!

@rust-timer build 2b144d8

@bors r+

rust-bors · 2026-10-28T11:55:15Z

📌 Commit 0dd45cb has been tentatively approved by Kobzol

It will be put into the queue for this repository once PR CI succeeds.

panstromek · 2026-10-28T11:55:49Z

This will need the PGO list update because match-stress got renamed to enum-stress, right?

panstromek · 2026-10-28T12:00:41Z

Looks like the try build silently ignores the benchmark if it's missing, that's a bit unfortunate.

JonathanBrouwer · 2026-10-28T12:01:23Z

@bors r-
I'll fix it

rust-bors · 2026-10-28T12:01:29Z

This pull request was unapproved.

View changes since this unapproval

panstromek · 2026-10-28T12:03:56Z

I'm a bit curious about the perf results now, we'll see whether the match stress is worth keeping.

JonathanBrouwer · 2026-10-28T12:17:01Z

Looks like the try build silently ignores the benchmark if it's missing, that's a bit unfortunate.

Fixed in rust-lang/rustc-perf#2631

This will need the PGO list update because match-stress got renamed to enum-stress, right?

Added as a commit to this PR

JonathanBrouwer · 2026-10-28T12:31:02Z

@bors try

Submodule update of rustc-perf

rust-timer · 2026-10-28T12:44:23Z

Finished benchmarking commit (2b144d8): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.9%	[0.1%, 2.9%]	24
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	6
Improvements ✅ (secondary)	-0.2%	[-0.4%, -0.1%]	21
All ❌✅ (primary)	-0.2%	[-0.4%, 0.2%]	7

Max RSS (memory usage)

Results (primary -0.1%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.8%]	8
Regressions ❌ (secondary)	2.1%	[0.6%, 4.6%]	5
Improvements ✅ (primary)	-1.8%	[-3.6%, -0.5%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-3.6%, 0.8%]	12

Cycles

Results (primary 0.7%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.4%, 3.3%]	17
Regressions ❌ (secondary)	3.6%	[0.5%, 6.7%]	11
Improvements ✅ (primary)	-0.8%	[-1.2%, -0.4%]	8
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	0.7%	[-1.2%, 3.3%]	25

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	3
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	3

Bootstrap: 490.666s -> 488.754s (-0.39%)
Artifact size: 405.86 MiB -> 406.05 MiB (0.05%)

panstromek · 2026-10-28T12:50:10Z

oh no, enum-stress got slower... I can't believe it

JonathanBrouwer · 2026-10-28T13:37:48Z

@rust-timer build c95a8f1

Kobzol · 2026-10-28T13:39:15Z

Ah, I thought we validated them already. Thanks, Jonathan!

rust-timer · 2026-10-28T14:27:07Z

Finished benchmarking commit (c95a8f1): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=iffy rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	3
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Max RSS (memory usage)

Results (primary -0.3%, secondary -4.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.5%, 0.9%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-3.5%, -0.4%]	7
Improvements ✅ (secondary)	-4.1%	[-4.1%, -4.1%]	1
All ❌✅ (primary)	-0.3%	[-3.5%, 0.9%]	14

Cycles

Results (primary 0.1%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.4%, 1.4%]	9
Regressions ❌ (secondary)	3.2%	[3.2%, 3.2%]	1
Improvements ✅ (primary)	-0.7%	[-1.2%, -0.4%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-1.2%, 1.4%]	16

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	3
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	3

Bootstrap: 490.666s -> 487.634s (-0.62%)
Artifact size: 405.86 MiB -> 405.93 MiB (0.02%)

rustbot · 2026-10-28T15:39:44Z

⚠️ Warning ⚠️

Some commits in this PR modify submodules.

If this was not intentional, see I changed a submodule on accident in the rustc dev guide.

Kobzol · 2026-10-28T15:48:43Z

@bors r+

rust-bors · 2026-10-28T15:48:57Z

📌 Commit 01943e6 has been tentatively approved by Kobzol

It will be put into the queue for this repository once PR CI succeeds.

@Kobzol

Submodule update of rustc-perf So we can play with rust-lang/rustc-perf#2624 r? @Kobzol

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

@Kobzol

Submodule update of rustc-perf So we can play with rust-lang/rustc-perf#2624 r? @Kobzol

…uwer Rollup of 23 pull requests Successful merges: - #165032 (stdarch subtree update) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #165123 (Temporarily drop macos-26 jobs) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #164981 (Reflection add TypeId::name) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

…uwer Rollup of 22 pull requests Successful merges: - #165032 (stdarch subtree update) - #165123 (Temporarily drop macos-26 jobs) - #165072 (Submodule update of rustc-perf) - #144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - #162342 (More stdarch regression tests) - #163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - #164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - #164916 (CI: rfl: move job forward to Linux v7.3) - #164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - #164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - #165083 (Gate `z` inline asm template modifier) - #165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - #161131 (Check associated const binding types) - #161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - #164315 (make powerpc `Complex` ABI GCC-compatible) - #164476 (Avoid ICE on None from prepare_vtable_segments) - #165003 (follow up for global-alloc-reentry test) - #165020 (Bless mir-opt panic-abort tests) - #165066 (skip max_repr_align in Layout::eq_abi) - #165080 (Syntactically allow C-variadics in parenthesized argument lists) - #165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - #165082 (Remove stability note from `rust_splat`)

@Kobzol

Rollup merge of #165072 - JonathanBrouwer:rustc-perf, r=Kobzol Submodule update of rustc-perf So we can play with rust-lang/rustc-perf#2624 r? @Kobzol

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#165032 (stdarch subtree update) - rust-lang/rust#165123 (Temporarily drop macos-26 jobs) - rust-lang/rust#165072 (Submodule update of rustc-perf) - rust-lang/rust#144090 (Make `IoSlice` and `IoSliceMut` methods unstably const) - rust-lang/rust#162342 (More stdarch regression tests) - rust-lang/rust#163909 (std: Test the exit behavior of `abort` and `abort_immediate`) - rust-lang/rust#164766 (Unstably introduce MVP edition migration lint `unmarked_unchecked_type_aliases` together with bikeshed attribute `#[rustc_unchecked_type_alias]`) - rust-lang/rust#164916 (CI: rfl: move job forward to Linux v7.3) - rust-lang/rust#164924 (Remove `TypeKind` from `rustc_codegen_ssa`) - rust-lang/rust#164969 (perf: avoid allocating HashSet in is_distinct check on small SwitchInts) - rust-lang/rust#165083 (Gate `z` inline asm template modifier) - rust-lang/rust#165087 (Fix flaky CI test `named_temp_file_new_creates_file`) - rust-lang/rust#161131 (Check associated const binding types) - rust-lang/rust#161418 (give next-solver's `evaluate_const` its own `try_evaluate_const` logic) - rust-lang/rust#164315 (make powerpc `Complex` ABI GCC-compatible) - rust-lang/rust#164476 (Avoid ICE on None from prepare_vtable_segments) - rust-lang/rust#165003 (follow up for global-alloc-reentry test) - rust-lang/rust#165020 (Bless mir-opt panic-abort tests) - rust-lang/rust#165066 (skip max_repr_align in Layout::eq_abi) - rust-lang/rust#165080 (Syntactically allow C-variadics in parenthesized argument lists) - rust-lang/rust#165081 (move `#[rustc_allow_const_fn_unstable]` attr check to attr parsing stage) - rust-lang/rust#165082 (Remove stability note from `rust_splat`)

Submodule update of rustc-perf

0dd45cb

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 28, 2026

rustbot assigned Kobzol Oct 28, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 28, 2026

Auto merge of #165072 - JonathanBrouwer:rustc-perf, r=<try>

2b144d8

Submodule update of rustc-perf

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2026

Fix RUSTC_PGO_CRATES

d03a647

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 28, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Oct 28, 2026

Auto merge of #165072 - JonathanBrouwer:rustc-perf, r=<try>

c95a8f1

Submodule update of rustc-perf

rustbot added the perf-regression Performance regression. label Oct 28, 2026

This comment has been minimized.

Sign in to view

Bump to include --exact validation

01943e6

JonathanBrouwer force-pushed the rustc-perf branch from 59df63c to 01943e6 Compare October 28, 2026 15:39

JonathanBrouwer requested a review from Kobzol October 28, 2026 15:40

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 28, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 28, 2026

Rollup merge of rust-lang#165072 - JonathanBrouwer:rustc-perf, r=Kobzol

fc14bb5

Submodule update of rustc-perf So we can play with rust-lang/rustc-perf#2624 r? @Kobzol

JonathanBrouwer mentioned this pull request Oct 28, 2026

Rollup of 22 pull requests #165095

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 29, 2026

Rollup merge of rust-lang#165072 - JonathanBrouwer:rustc-perf, r=Kobzol

76c078f

Submodule update of rustc-perf So we can play with rust-lang/rustc-perf#2624 r? @Kobzol

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 23 pull requests #165130

Closed

JonathanBrouwer mentioned this pull request Oct 29, 2026

Rollup of 22 pull requests #165151

Merged

rust-bors Bot merged commit d36b4f8 into rust-lang:main Oct 29, 2026
14 checks passed

rust-bors Bot pushed a commit that referenced this pull request Oct 29, 2026

Unrolled build for #165072 in rollup 165151

4b87c8f

Rollup merge of #165072 - JonathanBrouwer:rustc-perf, r=Kobzol Submodule update of rustc-perf So we can play with rust-lang/rustc-perf#2624 r? @Kobzol

rustbot added this to the 1.101.0 milestone Oct 29, 2026

Conversation

JonathanBrouwer commented Oct 28, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 28, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Oct 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 28, 2026

Uh oh!

Kobzol commented Oct 28, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 28, 2026

Uh oh!

panstromek commented Oct 28, 2026

Uh oh!

panstromek commented Oct 28, 2026

Uh oh!

JonathanBrouwer commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

panstromek commented Oct 28, 2026

Uh oh!

JonathanBrouwer commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Oct 28, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Oct 28, 2026

Overall result: ❌✅ regressions and improvements - please read:

Uh oh!

panstromek commented Oct 28, 2026

Uh oh!

JonathanBrouwer commented Oct 28, 2026

Uh oh!

This comment has been minimized.

Kobzol commented Oct 28, 2026

Uh oh!

rust-timer commented Oct 28, 2026

Overall result: ❌✅ regressions and improvements - please read:

Uh oh!

rustbot commented Oct 28, 2026

Uh oh!

Kobzol commented Oct 28, 2026

Uh oh!

rust-bors Bot commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JonathanBrouwer commented Oct 28, 2026 •

edited by rustbot

Loading

JonathanBrouwer commented Oct 28, 2026 •

edited

Loading

JonathanBrouwer commented Oct 28, 2026 •

edited

Loading