Skip to content

Canonicalize more comparison operators - #165221

Open
mu001999 wants to merge 1 commit into
rust-lang:mainfrom
mu001999-contrib:canonicalize-more-comparisons
Open

mu001999 wants to merge 1 commit into
rust-lang:mainfrom
mu001999-contrib:canonicalize-more-comparisons

Conversation

@mu001999

Copy link
Copy Markdown
Member

As a follow-up PR to #163373 (comment)

r? dianqk

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 31, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 31, 2026
@rustbot

rustbot commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

dianqk is currently at their maximum review capacity.
They may take a while to respond.

StorageLive(_7);
_7 = PtrMetadata(copy _1);
_8 = Le(copy _4, move _7);
_8 = Ge(move _7, copy _4);

@mu001999 mu001999 Oct 31, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because ReorderLocals

View changes since the review

@rust-log-analyzer

This comment has been minimized.

@mu001999
mu001999 force-pushed the canonicalize-more-comparisons branch from 2a9a24f to 700179f Compare October 31, 2026 07:38
@mu001999
mu001999 marked this pull request as ready for review October 31, 2026 13:47
@rustbot

rustbot commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 31, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants