Skip to content

Add r? @ghost suffix to Josh push PRs - #3098

Merged
Kobzol merged 1 commit into
rust-lang:mainfrom
Kobzol:josh-push-msg
Nov 18, 2026
Merged

Kobzol merged 1 commit into
rust-lang:mainfrom
Kobzol:josh-push-msg

Conversation

@Kobzol

@Kobzol Kobzol commented Nov 18, 2026

Copy link
Copy Markdown
Member

We want to remove this suffix from push PRs by default, but that would be a "breaking change" in the PR description (rust-lang/josh-sync#79).

If you want to keep the suffix, you can merge this PR. Otherwise, I can close it, and the suffix will disappear once the linked PR gets merged.

@rustbot

rustbot commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 18, 2026
@Kobzol
Kobzol merged commit 09b637a into rust-lang:main Nov 18, 2026
4 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Nov 18, 2026
@Kobzol
Kobzol deleted the josh-push-msg branch November 18, 2026 19:13
@tshepang

Copy link
Copy Markdown
Member

already had a prepared change for this locally, but because you are kool, you did all the work... thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants