Skip to content

feat(cargo): Style help like cargo nightly - #5908

Merged
ytmimi merged 3 commits into
rust-lang:masterfrom
epage:style
Sep 12, 2023
Merged

ytmimi merged 3 commits into
rust-lang:masterfrom
epage:style

Conversation

@epage

@epage epage commented Sep 11, 2023

Copy link
Copy Markdown
Contributor

As of rust-lang/cargo#12578, nightly cargo's help has terminal styling applied to it. This PR updates cargo-fmt to match so commands that appear built-in to the user all behave the same.

Other differences not address

  • Help headings
  • A footer recommending to run cargo help fmt (and providing an accompanying man page to be shown instead)

See rust-lang/cargo#12578 for screenshots of cargo and cargo run with different themes.

@calebcartwright calebcartwright left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, like the short and sweet ones!

@ytmimi - i can't recall the specifics but vaguely remember a semi-recent case where some change did something odd to our terminal coloring that you investigated. i'll defer merging this to you accordingly on the off chance there's anything you want to consider based on that (if not then feel free to bash the merge button!)

@calebcartwright calebcartwright added pr-ready-to-merge Status: PR is largely ready for merge, waiting for secondary review / last nits release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Sep 11, 2023

@ytmimi ytmimi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated output looks good to me, thanks!

Screen Shot 2023-09-11 at 10 11 06 PM

@ytmimi
ytmimi merged commit da7f678 into rust-lang:master Sep 12, 2023
@calebcartwright calebcartwright removed the pr-ready-to-merge Status: PR is largely ready for merge, waiting for secondary review / last nits label Sep 12, 2023
@epage
epage deleted the style branch September 12, 2023 18:45
@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants