Repository navigation
serde support for ChaCha - #1124
Merged
Merged
Conversation
The new getters correspond to existing setters.
Equivalent to the previous implementation, but clearer in intent. The representable-abstract-state framework introduced here is general-purpose and can also be used e.g. for serialization.
The format is semver-stable.
vks
approved these changes
May 12, 2021
vks
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks!
Could you please update the changelog?
Contributor
Author
|
@vks: CHANGELOG updated. While we're here, I also snuck in a small refactor of the internal API. The numbered-stream-param concept is now internal to guts. |
vks
approved these changes
May 12, 2021
vks
left a comment
Contributor
There was a problem hiding this comment.
Great, thanks! The test failures are on nightly only, which is not blocking this from getting merged.
Contributor
Author
|
Yeah, the test failure occurs on master too. It looks like serde is broken on nightly, because of this bug in a dependency: rust-lang/packed_simd#320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1101.