Skip to content

Automatic window minimize on auto clicking - #121

Merged
ryanlua merged 6 commits into
mainfrom
minimize-on-start
Oct 15, 2026
Merged

ryanlua merged 6 commits into
mainfrom
minimize-on-start

Conversation

@ryanlua

@ryanlua ryanlua commented Oct 14, 2026

Copy link
Copy Markdown
Owner

Closes #106

@ryanlua
ryanlua requested a balanced review from Copilot October 14, 2026 02:55
@ryanlua ryanlua self-assigned this Oct 14, 2026
@ryanlua ryanlua added the enhancement New feature or request label Oct 14, 2026
@ryanlua ryanlua linked an issue Oct 14, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new resources are absent from every non-US locale, resulting in mixed-language settings UI.

3 open findings
What changed in this PR

Adds configurable window minimization when auto-clicking starts and optional restoration when it stops.

Changes:

  • Adds two persisted window-behavior settings.
  • Minimizes/restores the main window based on those settings.
  • Adds English UI resources and reformats localized resource files.
File Description
AuraClick/​Pages/​MainPage.xaml.cs Applies minimize and restore behavior.
AuraClick/​Pages/​SettingsPage.xaml Adds behavior checkboxes.
AuraClick/​Pages/​SettingsPage.xaml.cs Persists the new preferences.
AuraClick/​Strings/​en-US/​Resources.resw Adds English labels and descriptions.
AuraClick/​Strings/​ar-SA/​Resources.resw XML formatting only.
AuraClick/​Strings/​bg-BG/​Resources.resw XML formatting only.
AuraClick/​Strings/​ca-ES/​Resources.resw XML formatting only.
AuraClick/​Strings/​cs-CZ/​Resources.resw XML formatting only.
AuraClick/​Strings/​da-DK/​Resources.resw XML formatting only.
AuraClick/​Strings/​de-DE/​Resources.resw XML formatting only.
AuraClick/​Strings/​el-GR/​Resources.resw XML formatting only.
AuraClick/​Strings/​en-GB/​Resources.resw XML formatting only.
AuraClick/​Strings/​es-ES/​Resources.resw XML formatting only.
AuraClick/​Strings/​es-MX/​Resources.resw XML formatting only.
AuraClick/​Strings/​et-EE/​Resources.resw XML formatting only.
AuraClick/​Strings/​eu-ES/​Resources.resw XML formatting only.
AuraClick/​Strings/​fi-FI/​Resources.resw XML formatting only.
AuraClick/​Strings/​fr-CA/​Resources.resw XML formatting only.
AuraClick/​Strings/​fr-FR/​Resources.resw XML formatting only.
AuraClick/​Strings/​gl-ES/​Resources.resw XML formatting only.
AuraClick/​Strings/​he-IL/​Resources.resw XML formatting only.
AuraClick/​Strings/​hr-HR/​Resources.resw XML formatting only.
AuraClick/​Strings/​hu-HU/​Resources.resw XML formatting only.
AuraClick/​Strings/​id-ID/​Resources.resw XML formatting only.
AuraClick/​Strings/​it-IT/​Resources.resw XML formatting only.
AuraClick/​Strings/​ja-JP/​Resources.resw XML formatting only.
AuraClick/​Strings/​ko-KR/​Resources.resw XML formatting only.
AuraClick/​Strings/​lt-LT/​Resources.resw XML formatting only.
AuraClick/​Strings/​lv-LV/​Resources.resw XML formatting only.
AuraClick/​Strings/​nb-NO/​Resources.resw XML formatting only.
AuraClick/​Strings/​nl-NL/​Resources.resw XML formatting only.
AuraClick/​Strings/​pl-PL/​Resources.resw XML formatting only.
AuraClick/​Strings/​pt-BR/​Resources.resw XML formatting only.
AuraClick/​Strings/​pt-PT/​Resources.resw XML formatting only.
AuraClick/​Strings/​ro-RO/​Resources.resw XML formatting only.
AuraClick/​Strings/​ru-RU/​Resources.resw XML formatting only.
AuraClick/​Strings/​sk-SK/​Resources.resw XML formatting only.
AuraClick/​Strings/​sl-SI/​Resources.resw XML formatting only.
AuraClick/​Strings/​sr-Latn-RS/​Resources.resw XML formatting only.
AuraClick/​Strings/​sv-SE/​Resources.resw XML formatting only.
AuraClick/​Strings/​th-TH/​Resources.resw XML formatting only.
AuraClick/​Strings/​tr-TR/​Resources.resw XML formatting only.
AuraClick/​Strings/​uk-UA/​Resources.resw XML formatting only.
AuraClick/​Strings/​vi-VN/​Resources.resw XML formatting only.
AuraClick/​Strings/​zh-CN/​Resources.resw XML formatting only.
AuraClick/​Strings/​zh-TW/​Resources.resw XML formatting only.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread AuraClick/Strings/en-US/Resources.resw
Comment thread AuraClick/Pages/SettingsPage.xaml.cs Outdated
Comment thread AuraClick/Strings/en-US/Resources.resw Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Click generation can begin before minimization, sending initial clicks to the wrong window.

2 open findings
1 resolved since last review
Previously missed (1)

In code that hasn't changed since last review

Medium severity Start auto-clicker after minimizing to prevent premature clicks

AuraClick/​Pages/​MainPage.xaml.cs:196

AutoClicker.Start() launches a worker that sends its first click before any delay (Helpers/AutoClicker.cs:72–85). With automatic minimization enabled, that worker can click the still-visible Aura Click window before this minimize call; a one-click limit can consume the entire run without reaching the window underneath. Move AutoClicker.Start() after the minimize block to prevent this ordering race.

🧠 Review effort: Balanced

@ryanlua
ryanlua merged commit 261ab01 into main Oct 15, 2026
4 checks passed
@ryanlua
ryanlua deleted the minimize-on-start branch October 15, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimize on start

2 participants