Skip to content

[WIP] Reworking Python build to support pip deployment. - #34

Closed
metasim wants to merge 2 commits into
developfrom
feature/pip
Closed

metasim wants to merge 2 commits into
developfrom
feature/pip

Conversation

@metasim
metasim requested review from bguseman and philvarner April 16, 2019 14:39
val ver = version.value
dest / s"${art.name}-python-$ver.zip"
},
test := {

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't yet work. Needs to set up the pyspark jar paths and test directories.

@bguseman bguseman left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without fully grokking all the details, this looks solid. Will a pip install pull in everything that's needed including jvm stuff?

@metasim

metasim commented Apr 18, 2019

Copy link
Copy Markdown
Author

Not sure about pulling in the jvm stuff. I'm wondering if something in the __init__.py might be required.

@metasim

metasim commented Jun 2, 2019

Copy link
Copy Markdown
Author

Replaced by locationtech#125

@metasim metasim closed this Jun 2, 2019
@metasim
metasim deleted the feature/pip branch July 2, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants