Skip to content

improvement(table): state the no hidden value rule (CUI-53) - #1225

Open
Cuervino wants to merge 1 commit into
development/1.0from
improvement/CUI-53-table-guideline
Open

Cuervino wants to merge 1 commit into
development/1.0from
improvement/CUI-53-table-guideline

Conversation

@Cuervino

Copy link
Copy Markdown
Contributor

A UI review of a product screen found a cell revealing its content on hover alone, with nothing on screen announcing that the content was there.

The guideline already covers column alignment, row selection and responsive columns. The +N trigger appears only under "Recovering the dropped values", so it reads as specific to columns hidden by a dropAt breakpoint. Nothing states the general rule.

What is added

Hidden values. No value is hidden. Content that does not fit is reached through a visible trigger, a question mark next to the content. A list of values that can be enumerated is the particular case: the first value, then the count as "+1" or "+2", then the question mark listing them all. There is no component for the count, so the section describes the composition.

One sentence in Row selection. The section says a selectable row shows a pointer cursor and a hover highlight. It did not say that a table with no onRowSelected has neither, which is the case the review ran into.

CUI-53. Related to CUI-52 and #1223, the Layout guideline from the same review.

🤖 Generated with Claude Code

A UI review found a cell revealing its content on hover alone, with nothing
on screen announcing that the content was there. The guideline documented the
"+N" trigger only under the dropped columns, so it read as specific to columns
hidden by a breakpoint.

Adds a Hidden values section stating the general rule, and one sentence in Row
selection saying that a table with no onRowSelected has no hover state.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@bert-e

bert-e commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Hello cuervino,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants