Skip to content

Remove [Xml]TreeBuilderActions and [Xml]TreeBuilderStep and move their implementations into [Xml]TreeBuilder - #274

Merged
bors-servo merged 4 commits into
servo:masterfrom
jbg:master
Aug 9, 2017
Merged

bors-servo merged 4 commits into
servo:masterfrom
jbg:master

Conversation

@jbg

@jbg jbg commented Jun 1, 2017 •

Copy link
Copy Markdown
Contributor

See issue #258


This change is Reviewable

@jdm

jdm commented Jun 4, 2017

Copy link
Copy Markdown
Member

r? @nox

@jdm

jdm commented Jul 7, 2017

Copy link
Copy Markdown
Member

Review ping, @nox.

@Ygg01

Ygg01 commented Aug 9, 2017

Copy link
Copy Markdown
Contributor

Reviewed 3 of 3 files at r1, 1 of 1 files at r4.
Review status: 2 of 6 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@jdm

jdm commented Aug 9, 2017

Copy link
Copy Markdown
Member

@bors-servo: r=Ygg01

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 524afe1 has been approved by Ygg01

@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 524afe1 with merge 6e5ef0d...

bors-servo pushed a commit that referenced this pull request Aug 9, 2017
Remove [Xml]TreeBuilderActions and [Xml]TreeBuilderStep and move their implementations into [Xml]TreeBuilder

See issue #258

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/274)
<!-- Reviewable:end -->
@bors-servo

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-travis
Approved by: Ygg01
Pushing 6e5ef0d to master...

@bors-servo
bors-servo merged commit 524afe1 into servo:master Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants