Finish case sensitivity settings in sub routers #17

Activity

1. jthomerson

   added this to the 1.0.0 milestone on Feb 26, 2019
2. jthomerson

   assigned

   yokuze

   on Feb 26, 2019
3. yokuze commented on Feb 28, 2019

   

   yokuze

   on Feb 28, 2019

   Contributor

   More actions

   It turns out that, in Express, route settings are not inherited from parent to child routers. In this example:

   const router1 = express.Router({ caseSensitive: true }),
         router1 = express.Router();
   
   router2.get('/World', (req, resp, next) => { console.log('uppercase /World'); next(); });
   router2.get('/world', (req, resp, next) => { console.log('lowercase /world'); next(); });
   router2.get('*', (req, resp) => { resp.send('world'); });
   
   router1.use('/hello', router2);
   app.use('/', router1);

   router2 does not inherit router1's case sensitivity settings.

   We should adjust our current behavior to avoid inheriting router settings.
4. yokuze

   added 3 commits that reference this issue on Mar 1, 2019

   fix: case-sensitive routing for sub-router mounting points (silvermin…

   ...

   e7e9d76

   fix: case-sensitive routing for sub-router mounting points (silvermin…

   ...

   3da1699

   fix: case-sensitive routing for sub-router mounting points (silvermin…

   ...

   aacfc53
5. yokuze

   added 2 commits that reference this issue on Mar 15, 2019

   fix: case-sensitive routing for sub-router mounting points (silvermin…

   ...

   dcc622e

   fix: case-sensitive routing for sub-router mounting points (silvermin…

   ...

   d7dfe46
6. jthomerson

   added a commit that references this issue on Mar 24, 2019

   Merge pull request #24 from yokuze/sub_router_case_sensitivity_17

   ...

   a7b2af1