So many warnings in pytest -Wall #692

Activity

1. simonw

   added

   bugSomething isn't workingSomething isn't working

   on Dec 12, 2025
2. simonw commented on Dec 12, 2025

   

   simonw

   on Dec 12, 2025

   OwnerAuthor

   More actions

   Claude Code fixed a TON of these: https://gistpreview.github.io/?730f0c5dc38528a1dd0615f330bd5481
3. simonw

   added 2 commits that reference this issue on Dec 12, 2025

   Database can now work as a context manager, refs #692

   f77ca0e

   Claude Code helped fix a ton of .close() warnings, refs #692

   ...

   81b0599
4. simonw commented on Dec 12, 2025

   

   simonw

   on Dec 12, 2025

   OwnerAuthor

   More actions

   Had Claude Code come up with this devious trick to help auto-close databases in tests:

   diff --git a/tests/conftest.py b/tests/conftest.py
   index a9a47bc..29a3b16 100644
   --- a/tests/conftest.py
   +++ b/tests/conftest.py
   @@ -14,6 +14,26 @@ def pytest_configure(config):
        sys._called_from_test = True
    
    
   +@pytest.fixture(autouse=True)
   +def close_all_databases():
   +    """Automatically close all Database objects created during a test."""
   +    databases = []
   +    original_init = Database.__init__
   +
   +    def tracking_init(self, *args, **kwargs):
   +        original_init(self, *args, **kwargs)
   +        databases.append(self)
   +
   +    Database.__init__ = tracking_init
   +    yield
   +    Database.__init__ = original_init
   +    for db in databases:
   +        try:
   +            db.close()
   +        except Exception:
   +            pass
   +
   +
    @pytest.fixture
    def fresh_db():
        db = Database(memory=True)
5. simonw

   added a commit that references this issue on Dec 12, 2025

   New autouse fixture to help with test warnings

   ...

   77359be
6. simonw

   closed this as completedin fd5b09fon Dec 12, 2025
7. simonw

   added a commit that references this issue on Dec 12, 2025

   Database as a context manager, fixed many pytest warnings

   ...

   fd5b09f
8. simonw

   added 2 commits that reference this issue on Jun 21, 2026

   Release 4.0rc1

   ...

   ee17bce

   Release 4.0rc1

   ...

   783d33b