Repository navigation
fix(credentials): declare service-account oauth policy on Snowflake, NetSuite, and Managed Agent tools - #9241
Merged
Conversation
…NetSuite, and Managed Agent tools The tool credential binding check fails closed when a tool declares no required oauth policy, so every Snowflake, NetSuite, and Managed Agent tool rejected its own saved credential. Declare the policy with credentialKind service-account (the Fivetran pattern), and refuse to generate tool metadata when a credential-taking tool cannot bind a provider.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryAdds service-account credential policies to 70 Snowflake, NetSuite, and Managed Agent tools.
No actionable new issues were found in the changes since the last review.
|
…tool param reachability audit
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oauthpolicy, so the fail-closed credential binding check inresolveCredentialTokenrejected every saved credential with "The selected credential does not belong to this tool provider" (70 tools)oauth: { required: true, provider, credentialKind: 'service-account' }on each via a shared constant, matching the Fivetran pattern; addsnowflake,netsuite,claude-platformtoOAuthServicecheck:tool-param-reachabilitynow fails when a tool with acredential/oauthCredentialparam has no requiredoauthpolicy or its provider matches no service — zero-tolerance invariant rather than a ratchet, since there are no remaining violationsadd-toolstemplate no longer implies theoauthblock is OAuth-only;validate-integrationchecks itType of Change
Testing
check:tool-param-reachabilityfails, passes with itlib/oauth/token-resolution.test.ts,tools/{snowflake,netsuite,managed_agent},tools/metadata.test.ts(183 passing)bun run lint,check:tool-metadata,check:tool-param-reachability,check:comment-hygiene,check:skills, block registry check; full audits/type-check/test via CIChecklist
test-auditauthoring gate)