You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
If both webhook URL and bot token are specified, action will run twice #219
I think this mostly just affects running the tests in this repo. Currently, each individual test in this repo's GH Action CI workflow file executes possibly multiple times because of this bug.
If a bot token is specified via an environment variable, then this conditional block will execute, which might result in posting or updating a message.
If you consume this action and use it using a bot token, but also specify the webhook URL environment variable, the action will POST to the webhook URL.
I think the solution is to do either-or: either use the bot token, or use the webhook URL. A fix for this issue should also clean up the usage of the webResponse variable in the code, as this is only set and used in the bot-token scenario.
👋 This is now fixed with @v2 where including both webhook and token will cause the step to exit with an error!
I do agree that having both techniques possible at the same time can cause a bit of confusion. I'd also be so interested in knowing of workflows that share payloads between different techniques in general 👀
Activity
Fix #219: either use the bot token to post a message, or POST to the …
Fix #219: either use the bot token to post a message, or POST to the …
zimeg commentedon Nov 16, 2024
👋 This is now fixed with
@v2where including bothwebhookandtokenwill cause the step to exit with an error!I do agree that having both techniques possible at the same time can cause a bit of confusion. I'd also be so interested in knowing of workflows that share payloads between different techniques in general 👀
I'll close this issue with the latest changes 👍