Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/develop.yml

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the default permissions are alright on a "development" workflow that's only run for experimenting with changes 🔍

Open to updating this however though!

Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:
steps:
- name: Checkout action
uses: actions/checkout@v4
with:
persist-credentials: false
- name: Setup the Node runtime for this project
uses: actions/setup-node@v4
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,13 @@ jobs:
build:
name: Build and tag a new version
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- name: Checkout the current code
uses: actions/checkout@v4
with:
persist-credentials: false
ref: ${{ github.event.release.tag_name }}

- name: Configure the runtime node
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@ jobs:
name: Run tests
runs-on: ubuntu-latest
environment: staging
permissions:
checks: write
steps:
- name: "build: checkout the latest changes"
uses: actions/checkout@v4
with:
persist-credentials: false
ref: ${{ github.event.pull_request.head.sha }}

- name: "build: setup the node runtime"
Expand Down Expand Up @@ -226,7 +229,7 @@ jobs:
- name: "chore(health): check up on recent changes to the health score"
uses: slackapi/slack-health-score@v0.1.1
with:
codecov_token: ${{ secrets.CODECOV_TOKEN }}
codecov_token: ${{ secrets.CODECOV_API_TOKEN }}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed to be an API token and has been added as a secret- https://github.com/slackapi/slack-health-score/?tab=readme-ov-file#api-tokens

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and this was changed because the standard upload token was being used: https://github.com/slackapi/slack-github-action/actions/runs/12173268802/job/33953505599#step:31:257

I don't think the testing workflow in this PR will show an update due to pull_request_target, but I'm optimistic with this change working here 🙏

github_token: ${{ secrets.GITHUB_TOKEN }}
extension: js
include: src