Skip to content

Patch spacing - #333

Closed
HardstylesDev wants to merge 1 commit into
slothpixel:masterfrom
HardstylesDev:patch-4
Closed

HardstylesDev wants to merge 1 commit into
slothpixel:masterfrom
HardstylesDev:patch-4

Conversation

@HardstylesDev

Copy link
Copy Markdown
Contributor

yee

@lgtm-com

lgtm-com Bot commented Mar 13, 2020

Copy link
Copy Markdown

This pull request introduces 1 alert when merging 934a760 into 5aa1aed - view on LGTM.com

new alerts:

  • 1 for Syntax error

@builder-247 builder-247 linked an issue Mar 13, 2020 that may be closed by this pull request
18 of 24 tasks
Comment thread processors/games/Duels.js
blitz_duel_ranger_kit_wins = 0,
blitz_duel_rounds_played = 0,
blitz_duel_scout_kit_wins = 0,
'blitz_duel_shadow knight_kit_wins' = 0,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I gave you the wrong advice...

This needs to be changed to

  'blitz_duel_shadow knight_kit_wins': blitz_duel_shadow_knight_kit_wins = 0,

for it to work.

Also you don't need to make a new PR for every change, you can just push to the same branch and it'll be automatically added.

@builder-247

Copy link
Copy Markdown
Member

Continued in #334

@builder-247 builder-247 removed a link to an issue Mar 13, 2020
18 of 24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants